fail mirroring if incoming check raises exception (#2709)

Author: Vladimir Kotal

opengrok-tools/src/main/python/opengrok_tools/mirror.py

@@ -368,7 +368,8 @@ def main():
                             break
                     except RepositoryException:
                         logger.error('Cannot determine incoming changes for '
-                                     'repository {}, driving on'.format(repo))
+                                     'repository {}'.format(repo))
+                        sys.exit(1)
 
                 if not got_incoming:
                     logger.info('No incoming changes for repositories in '

opengrok-tools/src/main/python/opengrok_tools/scm/mercurial.py

@@ -108,12 +108,13 @@ def incoming(self):
                               env_vars=self.env, logger=self.logger)
         cmd.execute()
         self.logger.debug(cmd.getoutputstr())
-        if cmd.getstate() != Command.FINISHED:
+        retcode = cmd.getretcode()
+        if cmd.getstate() != Command.FINISHED or retcode not in [0, 1]:
             cmd.log_error("failed to perform incoming")
             raise RepositoryException('failed to perform incoming command '
                                       'for repository {}'.format(self))
 
-        if cmd.getretcode() == 0:
+        if retcode == 0:
             return True
         else:
             return False