Fix Lua {Identifier} to exclude apostrophe

Also:
- Redefine using Unicode {Letter} and {Number}
  classes.

Author: idodeclare

src/org/opensolaris/opengrok/analysis/lua/Lua.lexh

@@ -22,7 +22,33 @@
  * Portions Copyright (c) 2017, Chris Fraire <[email protected]>.
  */
 
-Identifier = [a-zA-Z_] [a-zA-Z0-9_\']*
+/*
+ * Copyright © 1994–2017 Lua.org, PUC-Rio.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/*
+ * "Names (also called identifiers) in Lua can be any string of letters,
+ * digits, and underscores, not beginning with a digit...."
+ */
+Identifier = [\p{Letter}_] [\p{Letter}\p{Number}_]*
 
 Number = ([0][xX][0-9a-fA-F]+ | [0-9]+\.[0-9]+ |
     [0-9][0-9_]*) ([eE][+-]?[0-9]+)?

test/org/opensolaris/opengrok/analysis/lua/sample.lua

@@ -345,7 +345,7 @@ do
 
 
   function _M.get_body_info()
-    local args, err_code, raw_body, req_mime = get_body_info()
+    local args, err_code, raw_body, req_mime0 = get_body_info()
     if not raw_body then
       -- if our body was form-urlencoded and read via ngx.req.get_post_args()
       -- we need to retrieve the raw body because it was not retrieved by the

test/org/opensolaris/opengrok/analysis/lua/sample_xref.html

@@ -353,7 +353,7 @@
 <a class="l" name="345" href="#345">345</a>
 <a class="l" name="346" href="#346">346</a>
 <a class="l" name="347" href="#347">347</a>  <b>function</b> <a href="/source/s?defs=_M" class="intelliWindow-symbol" data-definition-place="undefined-in-file">_M</a>.<a class="d intelliWindow-symbol" href="#get_body_info" data-definition-place="defined-in-file">get_body_info</a>()
-<a class="l" name="348" href="#348">348</a>    <b>local</b> <a href="/source/s?defs=args" class="intelliWindow-symbol" data-definition-place="undefined-in-file">args</a>, <a href="/source/s?defs=err_code" class="intelliWindow-symbol" data-definition-place="undefined-in-file">err_code</a>, <a href="/source/s?defs=raw_body" class="intelliWindow-symbol" data-definition-place="undefined-in-file">raw_body</a>, <a href="/source/s?defs=req_mime" class="intelliWindow-symbol" data-definition-place="undefined-in-file">req_mime</a> = <a class="d intelliWindow-symbol" href="#get_body_info" data-definition-place="defined-in-file">get_body_info</a>()
+<a class="l" name="348" href="#348">348</a>    <b>local</b> <a href="/source/s?defs=args" class="intelliWindow-symbol" data-definition-place="undefined-in-file">args</a>, <a href="/source/s?defs=err_code" class="intelliWindow-symbol" data-definition-place="undefined-in-file">err_code</a>, <a href="/source/s?defs=raw_body" class="intelliWindow-symbol" data-definition-place="undefined-in-file">raw_body</a>, <a href="/source/s?defs=req_mime0" class="intelliWindow-symbol" data-definition-place="undefined-in-file">req_mime0</a> = <a class="d intelliWindow-symbol" href="#get_body_info" data-definition-place="defined-in-file">get_body_info</a>()
 <a class="l" name="349" href="#349">349</a>    <b>if</b> <b>not</b> <a href="/source/s?defs=raw_body" class="intelliWindow-symbol" data-definition-place="undefined-in-file">raw_body</a> <b>then</b>
 <a class="hl" name="350" href="#350">350</a>      <span class="c">-- if our body was form-urlencoded and read via ngx.req.get_post_args()</span>
 <a class="l" name="351" href="#351">351</a>      <span class="c">-- we need to retrieve the raw body because it was not retrieved by the</span>

test/org/opensolaris/opengrok/analysis/lua/samplesymbols.txt

@@ -177,7 +177,7 @@ get_body_info
 args
 err_code
 raw_body
-req_mime
+req_mime0
 get_body_info
 raw_body
 raw_body