Fix some Google Lighthouse warnings

Author: ahornace

opengrok-indexer/src/main/java/org/opengrok/indexer/web/Util.java

@@ -1507,6 +1507,7 @@ public static String linkify(String url, boolean newTab) {
                 attrs.put("title", String.format("Link to %s", Util.encode(url)));
                 if (newTab) {
                     attrs.put("target", "_blank");
+                    attrs.put("rel", "noreferrer");
                 }
                 return buildLink(url, attrs);
             } catch (URISyntaxException | MalformedURLException ex) {
@@ -1587,6 +1588,7 @@ public static String buildLink(String name, String url, boolean newTab)
         attrs.put("href", url);
         if (newTab) {
             attrs.put("target", "_blank");
+            attrs.put("rel", "noreferrer");
         }
         return buildLink(name, attrs);
     }

opengrok-indexer/src/test/java/org/opengrok/indexer/web/UtilTest.java

@@ -389,6 +389,7 @@ public void testLinkify() throws URISyntaxException, MalformedURLException {
         assertTrue(Util.linkify("https://example.com", true).contains("target=\"_blank\""));
         assertTrue(Util.linkify("http://www.example.com?param=1&param2=2", true).contains("target=\"_blank\""));
         assertTrue(Util.linkify("https://www.example.com:8080/other/page", true).contains("target=\"_blank\""));
+        assertTrue(Util.linkify("https://www.example.com:8080/other/page", true).contains("rel=\"noreferrer\""));
 
         assertFalse(Util.linkify("http://www.example.com", false).contains("target=\"_blank\""));
         assertFalse(Util.linkify("https://example.com", false).contains("target=\"_blank\""));
@@ -467,26 +468,29 @@ public void testLinkifyPattern() {
         String expected
                 = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, "
                 + "sed do eiusmod tempor incididunt as per "
-                + "<a href=\"http://www.example.com?bug=12345698\" target=\"_blank\">12345698</a> ut labore et dolore magna "
+                + "<a href=\"http://www.example.com?bug=12345698\" rel=\"noreferrer\" target=\"_blank\">12345698</a>"
+                + " ut labore et dolore magna "
                 + "aliqua. bug3333fff Ut enim ad minim veniam, quis nostrud exercitation "
                 + "ullamco laboris nisi ut aliquip ex ea introduced in "
-                + "<a href=\"http://www.example.com?bug=9791216541\" target=\"_blank\">9791216541</a> commodo consequat. "
+                + "<a href=\"http://www.example.com?bug=9791216541\" rel=\"noreferrer\" target=\"_blank\">9791216541</a>"
+                + " commodo consequat. "
                 + "Duis aute irure dolor in reprehenderit in voluptate velit "
                 + "esse cillum dolore eu fixes "
-                + "<a href=\"http://www.example.com?bug=132469187\" target=\"_blank\">132469187</a> fugiat nulla pariatur. Excepteur sint "
+                + "<a href=\"http://www.example.com?bug=132469187\" rel=\"noreferrer\" target=\"_blank\">132469187</a>"
+                + " fugiat nulla pariatur. Excepteur sint "
                 + "occaecat bug6478abc cupidatat non proident, sunt in culpa qui officia "
                 + "deserunt mollit anim id est laborum.";
         String expected2
                 = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, "
                 + "sed do eiusmod tempor incididunt as per 12345698 ut labore et dolore magna "
                 + "aliqua. "
-                + "<a href=\"http://www.other-example.com?bug=3333\" target=\"_blank\">bug3333fff</a>"
+                + "<a href=\"http://www.other-example.com?bug=3333\" rel=\"noreferrer\" target=\"_blank\">bug3333fff</a>"
                 + " Ut enim ad minim veniam, quis nostrud exercitation "
                 + "ullamco laboris nisi ut aliquip ex ea introduced in 9791216541 commodo consequat. "
                 + "Duis aute irure dolor in reprehenderit in voluptate velit "
                 + "esse cillum dolore eu fixes 132469187 fugiat nulla pariatur. Excepteur sint "
                 + "occaecat "
-                + "<a href=\"http://www.other-example.com?bug=6478\" target=\"_blank\">bug6478abc</a>"
+                + "<a href=\"http://www.other-example.com?bug=6478\" rel=\"noreferrer\" target=\"_blank\">bug6478abc</a>"
                 + " cupidatat non proident, sunt in culpa qui officia "
                 + "deserunt mollit anim id est laborum.";
 

opengrok-web/src/main/webapp/WEB-INF/web.xml

@@ -47,11 +47,17 @@
             <param-value>max-age=86400</param-value>
         </init-param>
     </filter>
+    <filter>
+        <filter-name>ExpiresOneYearFilter</filter-name>
+        <filter-class>org.opengrok.web.ResponseHeaderFilter</filter-class>
+        <init-param>
+            <param-name>Cache-Control</param-name>
+            <param-value>max-age=31536000</param-value>
+        </init-param>
+    </filter>
     <filter-mapping>
         <filter-name>ExpiresOneDayFilter</filter-name>
-        <url-pattern>/default/*</url-pattern>
-        <url-pattern>/js/*</url-pattern>
-        <url-pattern>/webjars/*</url-pattern>
+        <url-pattern>/manifest.json</url-pattern>
         <dispatcher>REQUEST</dispatcher>
     </filter-mapping>
     <filter-mapping>
@@ -65,6 +71,13 @@
         <url-pattern>/eforbidden</url-pattern>
         <dispatcher>REQUEST</dispatcher>
     </filter-mapping>
+    <filter-mapping>
+        <filter-name>ExpiresOneYearFilter</filter-name>
+        <url-pattern>/default/*</url-pattern>
+        <url-pattern>/js/*</url-pattern>
+        <url-pattern>/webjars/*</url-pattern>
+        <dispatcher>REQUEST</dispatcher>
+    </filter-mapping>
     <filter>
         <filter-name>CookieFilter</filter-name>
         <filter-class>org.opengrok.web.CookieFilter</filter-class>

opengrok-web/src/main/webapp/default/img/google-touch-icon.png

@@ -1072,8 +1072,9 @@ a.scope            { /* scope              */ color: steelblue; font-weight: bol
 }
 
 @font-face {
+    font-display: swap;
     font-family: SunSans;
-    src: url('./font/SunSansRegular.woff2');
+    src: url('./font/SunSansRegular.woff2') format('woff2');
 }
 
 .link-no-decoration {

opengrok-web/src/main/webapp/default/style-1.0.1.css renamed to opengrok-web/src/main/webapp/default/style-1.0.2.css

@@ -291,6 +291,7 @@ document.domReady.push(function() {domReadyHistory();});
                 </a></td>
             <td><%
                 %><input type="radio"
+                        aria-label="From"
                         data-revision-1="<%= (start + count) %>"
                         data-revision-2="<%= revision2 %>"
                         data-diff-revision="<%= QueryParameters.REVISION_1_PARAM %>"
@@ -308,6 +309,7 @@ document.domReady.push(function() {domReadyHistory();});
                 %>/><%
 
                 %><input type="radio"
+                        aria-label="To"
                         data-revision-1="<%= revision1 %>"
                         data-revision-2="<%= (start + count) %>"
                         data-diff-revision="<%= QueryParameters.REVISION_2_PARAM %>"

opengrok-web/src/main/webapp/history.jsp

@@ -45,7 +45,7 @@ org.opengrok.web.Scripts"
     PageConfig cfg = PageConfig.get(request);
     String styleDir = cfg.getCssDir();
     String ctxPath = request.getContextPath();
-    String dstyle = styleDir + '/' + "style-1.0.1.min.css";
+    String dstyle = styleDir + '/' + "style-1.0.2.min.css";
     String pstyle = styleDir + '/' + "print-1.0.1.min.css";
     String mstyle = styleDir + '/' + "mandoc-1.0.0.min.css";
 %><!DOCTYPE html>
@@ -60,7 +60,8 @@ org.opengrok.web.Scripts"
 <link rel="icon" href="<%=styleDir%>/img/favicon.svg">
 <link rel="mask-icon" href="<%=styleDir%>/img/mask-icon.svg" color="#000000">
 <link rel="apple-touch-icon" href="<%=styleDir%>/img/apple-touch-icon.png">
-<link rel="manifest" href="<%=styleDir%>/manifest.json">
+<link rel="manifest" href="<%=ctxPath%>/manifest.json">
+<link rel="preload" href="<%=styleDir%>/font/SunSansRegular.woff2" as="font" type="font/woff2" crossorigin>
 <link rel="stylesheet" type="text/css" media="all"
     title="Default" href="<%= dstyle %>" />
 <link rel="alternate stylesheet" type="text/css" media="all"

opengrok-web/src/main/webapp/httpheader.jspf

@@ -2,10 +2,12 @@
   "name": "OpenGrok - a wicked fast source browser",
   "short_name": "OpenGrok",
   "icons": [{
-    "src": "./img/google-touch-icon.png",
-    "sizes": "512x512"
+    "src": "./default/img/google-touch-icon.png",
+    "sizes": "512x512",
+    "purpose": "any maskable"
   }],
   "background_color": "#ffffff",
   "theme_color": "#ffffff",
-  "display": "fullscreen"
+  "display": "fullscreen",
+  "start_url": "./"
 }

opengrok-web/src/main/webapp/default/manifest.json renamed to opengrok-web/src/main/webapp/manifest.json

@@ -97,7 +97,7 @@ org.opengrok.indexer.web.Util"%><%
 	<%
     }
         %><li><input type="text" id="search" name="<%= QueryParameters.FULL_SEARCH_PARAM %>"
-                  class="q" /></li>
+                  class="q" aria-label="Search"/></li>
             <li><input type="submit" value="Search" class="submit" /></li><%
     Project proj = cfg.getProject();
     String[] vals = cfg.getSearchOnlyIn();