Skip to content

Commit 7f142e0

Browse files
ahornaceVladimir Kotal
authored andcommitted
Add additional classes to configuration classloader whitelist
1 parent 6b6fd55 commit 7f142e0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/ConfigurationClassLoader.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import java.util.ArrayList;
3636
import java.util.Collections;
3737
import java.util.HashMap;
38+
import java.util.HashSet;
3839
import java.util.Set;
3940
import java.util.TreeSet;
4041
import java.util.stream.Collectors;
@@ -53,15 +54,18 @@ public class ConfigurationClassLoader extends ClassLoader {
5354
AuthorizationStack.class,
5455
Collections.class,
5556
Configuration.class,
57+
Enum.class,
5658
Filter.class,
5759
Group.class,
5860
HashMap.class,
61+
HashSet.class,
5962
IAuthorizationPlugin.class,
6063
IgnoredNames.class,
6164
LuceneLockName.class,
6265
Project.class,
6366
RemoteSCM.class,
6467
RepositoryInfo.class,
68+
Set.class,
6569
StatsdConfig.class,
6670
StatsdFlavor.class,
6771
String.class,

opengrok-indexer/src/test/java/org/opengrok/indexer/configuration/ConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,9 @@ void testDeserializationOfNotWhiteListedClassThrowsError(final String exploit) {
225225

226226
@Test
227227
void testLoadingValidConfiguration() throws IOException {
228-
try (var bf = new BufferedReader(new InputStreamReader(ConfigurationTest.class.getClassLoader()
228+
try (var br = new BufferedReader(new InputStreamReader(ConfigurationTest.class.getClassLoader()
229229
.getResourceAsStream("configuration/valid_configuration.xml")))) {
230-
String xml = bf.lines().collect(Collectors.joining(System.lineSeparator()));
230+
String xml = br.lines().collect(Collectors.joining(System.lineSeparator()));
231231
var config = Configuration.makeXMLStringAsConfiguration(xml);
232232
assertEquals("/opt/opengrok_data", config.getDataRoot());
233233
}

0 commit comments

Comments
 (0)