Skip to content

Commit 819d147

Browse files
author
Vladimir Kotal
committed
refactor do_api_call() to use a dictionary
1 parent 0ee403d commit 819d147

File tree

1 file changed

+10
-11
lines changed
  • opengrok-tools/src/main/python/opengrok_tools/utils

1 file changed

+10
-11
lines changed

opengrok-tools/src/main/python/opengrok_tools/utils/restful.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,16 @@
2929

3030

3131
def do_api_call(command, uri, verb, headers, data):
32-
logger = logging.getLogger(__name__)
33-
34-
if verb == 'PUT':
35-
return put(logger, uri, headers=headers, data=data)
36-
elif verb == 'POST':
37-
return post(logger, uri, headers=headers, data=data)
38-
elif verb == 'DELETE':
39-
return delete(logger, uri, headers=headers, data=data)
40-
else:
41-
raise Exception('Unknown HTTP verb in command {}'.
42-
format(command))
32+
verbs = {
33+
'PUT': put,
34+
'POST': post,
35+
'DELETE': delete
36+
}
37+
handler = verbs.get(verb)
38+
if handler is not None:
39+
logger = logging.getLogger(__name__)
40+
return handler(logger, uri, headers=headers, data=data)
41+
raise Exception('Unknown HTTP verb in command {}'.format(command))
4342

4443

4544
def call_rest_api(command, pattern, name):

0 commit comments

Comments
 (0)