Enable checkstyle for web module (#2259)

Author: ahornace

opengrok-web/pom.xml

@@ -196,6 +196,11 @@ Portions Copyright (c) 2018, Chris Fraire <[email protected]>.
                     </argLine>
                 </configuration>
             </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+            </plugin>
         </plugins>
     </build>
 

opengrok-web/src/main/java/org/opengrok/web/AuthorizationFilter.java

@@ -18,7 +18,7 @@
  */
 
 /*
- * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved.
  */
 package org.opengrok.web;
 
@@ -34,7 +34,6 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 import org.opengrok.indexer.configuration.Project;
-import org.opengrok.indexer.configuration.RuntimeEnvironment;
 import org.opengrok.indexer.logger.LoggerFactory;
 import org.opengrok.indexer.web.PageConfig;
 import org.opengrok.web.api.v1.RestApp;

opengrok-web/src/main/java/org/opengrok/web/DirectoryListing.java

@@ -18,7 +18,7 @@
  */
 
 /*
- * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
  * Portions Copyright 2011 Jens Elkner.
  * Portions Copyright (c) 2017-2018, Chris Fraire <[email protected]>.
  */
@@ -49,7 +49,7 @@
  */
 public class DirectoryListing {
 
-    protected final static String DIRECTORY_SIZE_PLACEHOLDER = "-";
+    protected static final String DIRECTORY_SIZE_PLACEHOLDER = "-";
     private final EftarFileReader desc;
     private final long now;
 

opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/ConfigurationController.java

@@ -18,12 +18,11 @@
  */
 
 /*
- * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
  */
 package org.opengrok.web.api.v1.controller;
 
 import org.opengrok.indexer.configuration.RuntimeEnvironment;
-import org.opengrok.indexer.util.ClassUtil;
 import org.opengrok.web.api.v1.suggester.provider.service.SuggesterService;
 
 import javax.inject.Inject;

pom.xml

@@ -293,7 +293,7 @@ Portions Copyright (c) 2018, Chris Fraire <[email protected]>.
                         <dependency>
                             <groupId>com.puppycrawl.tools</groupId>
                             <artifactId>checkstyle</artifactId>
-                            <version>8.11</version>
+                            <version>8.17</version>
                         </dependency>
                     </dependencies>
                     <executions>