Dash B option enhancement (#1780)

fixes #1770

Author: shaehn

src/org/opensolaris/opengrok/configuration/Configuration.java

@@ -357,7 +357,7 @@ public Configuration() {
         cmds = new HashMap<>();
         setAllowedSymlinks(new HashSet<>());
         setAuthorizationWatchdogEnabled(false);
-        setBugPage("http://bugs.myserver.org/bugdatabase/view_bug.do?bug_id=");
+        //setBugPage("http://bugs.myserver.org/bugdatabase/view_bug.do?bug_id=");
         setBugPattern("\\b([12456789][0-9]{6})\\b");
         setCachePages(5);
         setCommandTimeout(600); // 10 minutes
@@ -392,7 +392,7 @@ public Configuration() {
         setRamBufferSize(defaultRamBufferSize); //MB
         setRemoteScmSupported(RemoteSCM.OFF);
         setRepositories(new ArrayList<>());
-        setReviewPage("http://arc.myserver.org/caselog/PSARC/");
+        //setReviewPage("http://arc.myserver.org/caselog/PSARC/");
         setReviewPattern("\\b(\\d{4}/\\d{3})\\b"); // in form e.g. PSARC 2008/305
         setRevisionMessageCollapseThreshold(200);
         setScanningDepth(defaultScanningDepth); // default depth of scanning for repositories
@@ -403,7 +403,7 @@ public Configuration() {
         setTagsEnabled(false);
         setUrlPrefix("/source/s?");
         //setUrlPrefix("../s?"); // TODO generate relative search paths, get rid of -w <webapp> option to indexer !
-        setUserPage("http://www.myserver.org/viewProfile.jspa?username=");
+        //setUserPage("http://www.myserver.org/viewProfile.jspa?username=");
         // Set to empty string so we can append it to the URL
         // unconditionally later.
         setUserPageSuffix("");

src/org/opensolaris/opengrok/index/CommandLineOptions.java

@@ -74,7 +74,7 @@ public CommandLineOptions() {
         options.add(new Option('?', null, "Help"));
         options.add(new Option('A', ".ext|prefix.:analyzer", "Files with the named prefix/extension should be analyzed with the specified class"));
         options.add(new Option('a', ON_OFF, "Allow or disallow leading wildcards in a search"));
-        options.add(new Option('B', "url", "Base URL of the user Information provider. Default: \"http://www.myserver.org/viewProfile.jspa?username=\""));
+        options.add(new Option('B', "url", "Base URL of the user Information provider. Example: \"http://www.myserver.org/viewProfile.jspa?username=\". Use \"none\" to disable link."));
         options.add(new Option('C', null, "Print per project percentage progress information(I/O extensive, since one read through dir structure is made before indexing, needs -v, otherwise it just goes to the log)"));
         options.add(new Option('c', "/path/to/ctags", "Path to Exuberant Ctags from http://ctags.sf.net by default takes the Exuberant Ctags in PATH."));
         options.add(new Option('d', "/path/to/data/root", "The directory where OpenGrok stores the generated data"));

test/org/opensolaris/opengrok/configuration/RuntimeEnvironmentTest.java

@@ -139,7 +139,8 @@ public void testProjects() throws IOException {
         assertNull(instance.getDefaultProjects());
 
         File file = new File("/opengrok_automatic_test/foo/bar");
-        instance.setSourceRoot("/opengrok_automatic_test/foo");
+        File folder = new File("/opengrok_automatic_test/foo");
+        instance.setSourceRoot(folder.getCanonicalPath());
         Project p = new Project("bar");
         p.setPath("/bar");
         assertEquals("/bar", p.getId());
@@ -299,18 +300,18 @@ public void testIgnoredNames() {
     public void testUserPage() {
         RuntimeEnvironment instance = RuntimeEnvironment.getInstance();
         String page = "http://www.myserver.org/viewProfile.jspa?username=";
+        assertNull(instance.getUserPage());   // default value is null
+        instance.setUserPage(page);
         assertEquals(page, instance.getUserPage());
-        instance.setUserPage(page.substring(5));
-        assertEquals(page.substring(5), instance.getUserPage());
     }
 
     @Test
     public void testBugPage() {
         RuntimeEnvironment instance = RuntimeEnvironment.getInstance();
         String page = "http://bugs.myserver.org/bugdatabase/view_bug.do?bug_id=";
+        assertNull(instance.getBugPage());   // default value is null
+        instance.setBugPage(page);
         assertEquals(page, instance.getBugPage());
-        instance.setBugPage(page.substring(5));
-        assertEquals(page.substring(5), instance.getBugPage());
     }
 
     @Test
@@ -357,9 +358,9 @@ public void testInvalidBugPattern() {
     public void testReviewPage() {
         RuntimeEnvironment instance = RuntimeEnvironment.getInstance();
         String page = "http://arc.myserver.org/caselog/PSARC/";
+        assertNull(instance.getReviewPage());   // default value is null
+        instance.setReviewPage(page);
         assertEquals(page, instance.getReviewPage());
-        instance.setReviewPage(page.substring(5));
-        assertEquals(page.substring(5), instance.getReviewPage());
     }
 
     @Test