Skip to content

Commit 92f4530

Browse files
author
Vladimir Kotal
committed
dedup checkFile() and checkFileResolve()
1 parent c5a808b commit 92f4530

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

opengrok-web/src/main/java/org/opengrok/web/PageConfig.java

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,18 +1202,16 @@ private static String trailingSlash(String path) {
12021202
: "";
12031203
}
12041204

1205-
private File checkFile(File dir, String name, boolean compressed) {
1205+
private File checkFile(File file, File dir, String name, boolean compressed) {
12061206
File f;
12071207
if (compressed) {
12081208
f = new File(dir, TandemPath.join(name, ".gz"));
1209-
if (f.exists() && f.isFile()
1210-
&& f.lastModified() >= resourceFile.lastModified()) {
1209+
if (f.exists() && f.isFile() && f.lastModified() >= file.lastModified()) {
12111210
return f;
12121211
}
12131212
}
12141213
f = new File(dir, name);
1215-
if (f.exists() && f.isFile()
1216-
&& f.lastModified() >= resourceFile.lastModified()) {
1214+
if (f.exists() && f.isFile() && f.lastModified() >= file.lastModified()) {
12171215
return f;
12181216
}
12191217
return null;
@@ -1224,20 +1222,8 @@ private File checkFileResolve(File dir, String name, boolean compressed) {
12241222
if (!lresourceFile.canRead()) {
12251223
lresourceFile = new File(PATH_SEPARATOR_STRING);
12261224
}
1227-
File f;
1228-
if (compressed) {
1229-
f = new File(dir, TandemPath.join(name, ".gz"));
1230-
if (f.exists() && f.isFile()
1231-
&& f.lastModified() >= lresourceFile.lastModified()) {
1232-
return f;
1233-
}
1234-
}
1235-
f = new File(dir, name);
1236-
if (f.exists() && f.isFile()
1237-
&& f.lastModified() >= lresourceFile.lastModified()) {
1238-
return f;
1239-
}
1240-
return null;
1225+
1226+
return checkFile(lresourceFile, dir, name, compressed);
12411227
}
12421228

12431229
/**
@@ -1280,7 +1266,7 @@ public File[] findDataFiles(List<String> filenames) {
12801266
* @return {@code null} if not found, the file otherwise.
12811267
*/
12821268
public File findDataFile() {
1283-
return checkFile(new File(getEnv().getDataRootPath() + Prefix.XREF_P),
1269+
return checkFile(resourceFile, new File(getEnv().getDataRootPath() + Prefix.XREF_P),
12841270
getPath(), env.isCompressXref());
12851271
}
12861272

0 commit comments

Comments
 (0)