Skip to content

Commit 9debd33

Browse files
author
Vladimir Kotal
committed
propagate debug flag to config-merge
fixes #2337
1 parent c6df98b commit 9debd33

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

tools/src/main/python/command.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,9 @@ def getoutput(self):
366366
def geterroutput(self):
367367
return self.err
368368

369+
def geterroutputstr(self):
370+
return "".join(self.err).strip()
371+
369372
def getstate(self):
370373
return self.state
371374

tools/src/main/python/projadm.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ def exec_command(doit, logger, cmd, msg):
6767
logger.error("Error output: {}".format(cmd.geterroutput()))
6868
sys.exit(1)
6969

70+
logger.debug(cmd.geterroutputstr())
71+
7072
return cmd.getoutput()
7173

7274

@@ -137,9 +139,10 @@ def config_refresh(doit, logger, basedir, uri, configmerge, jar_file,
137139
else:
138140
logger.info('Refreshing configuration '
139141
'(merging with read-only config)')
142+
configmerge_cmd = configmerge
143+
configmerge_cmd.extend(['-a', jar_file, roconfig, fcur.name])
140144
merged_config = exec_command(doit, logger,
141-
[configmerge, '-a', jar_file,
142-
roconfig, fcur.name],
145+
configmerge_cmd,
143146
"cannot merge configuration")
144147
with tempfile.NamedTemporaryFile() as fmerged:
145148
logger.debug("Temporary file for merged config: {}".
@@ -276,6 +279,10 @@ def project_delete(logger, project, uri, doit=True, deletesource=False):
276279
"the config merge script")
277280
sys.exit(1)
278281

282+
configmerge = [configmerge_file]
283+
if args.debug:
284+
configmerge.append('-D')
285+
279286
if args.jar is None:
280287
logger.error('jar file needed for config merge tool, '
281288
'use --jar to specify one')
@@ -299,7 +306,7 @@ def project_delete(logger, project, uri, doit=True, deletesource=False):
299306
config_refresh(doit=doit, logger=logger,
300307
basedir=args.base,
301308
uri=uri,
302-
configmerge=configmerge_file,
309+
configmerge=configmerge,
303310
jar_file=args.jar,
304311
roconfig=args.roconfig)
305312
elif args.delete:
@@ -312,14 +319,14 @@ def project_delete(logger, project, uri, doit=True, deletesource=False):
312319
config_refresh(doit=doit, logger=logger,
313320
basedir=args.base,
314321
uri=uri,
315-
configmerge=configmerge_file,
322+
configmerge=configmerge,
316323
jar_file=args.jar,
317324
roconfig=args.roconfig)
318325
elif args.refresh:
319326
config_refresh(doit=doit, logger=logger,
320327
basedir=args.base,
321328
uri=uri,
322-
configmerge=configmerge_file,
329+
configmerge=configmerge,
323330
jar_file=args.jar,
324331
roconfig=args.roconfig)
325332
else:

0 commit comments

Comments
 (0)