add quotes for path logging

Author: vladak

opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java

@@ -688,9 +688,9 @@ public void update() throws IOException {
 
                     args.curCount = 0;
                     Statistics elapsed = new Statistics();
-                    LOGGER.log(Level.INFO, "Starting indexing of directory {0}", dir);
+                    LOGGER.log(Level.INFO, "Starting indexing of directory ''{0}''", dir);
                     indexParallel(dir, args);
-                    elapsed.report(LOGGER, String.format("Done indexing of directory %s", dir),
+                    elapsed.report(LOGGER, String.format("Done indexing of directory '%s'", dir),
                             "indexer.db.directory.index");
 
                     /*

opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java

@@ -997,9 +997,9 @@ private static void configureFileAnalyzer(String fileSpec, String analyzer) {
      */
     public static void writeConfigToFile(RuntimeEnvironment env, String filename) throws IOException {
         if (filename != null) {
-            LOGGER.log(Level.INFO, "Writing configuration to {0}", filename);
+            LOGGER.log(Level.INFO, "Writing configuration to ''{0}''", filename);
             env.writeConfiguration(new File(filename));
-            LOGGER.log(Level.INFO, "Done writing configuration to {0}", filename);
+            LOGGER.log(Level.INFO, "Done writing configuration to ''{0}''", filename);
         }
     }
 

opengrok-indexer/src/main/java/org/opengrok/indexer/index/PendingFileCompleter.java

@@ -363,9 +363,9 @@ private void doDelete(PendingFileDeletionExec del) {
 
     private void doDelete(File f) {
         if (f.delete()) {
-            LOGGER.log(Level.FINER, "Deleted obsolete file: {0}", f.getPath());
+            LOGGER.log(Level.FINER, "Deleted obsolete file: ''{0}''", f.getPath());
         } else if (f.exists()) {
-            LOGGER.log(Level.WARNING, "Failed to delete obsolete file: {0}",
+            LOGGER.log(Level.WARNING, "Failed to delete obsolete file: ''{0}''",
                     f.getPath());
         }
     }
@@ -375,12 +375,12 @@ private void doRename(PendingFileRenamingExec ren) throws IOException {
             Files.move(Paths.get(ren.source), Paths.get(ren.target),
                 StandardCopyOption.REPLACE_EXISTING);
         } catch (IOException e) {
-            LOGGER.log(Level.WARNING, "Failed to move file: {0} -> {1}",
+            LOGGER.log(Level.WARNING, "Failed to move file: ''{0}'' -> ''{1}''",
                 new Object[]{ren.source, ren.target});
             throw e;
         }
         if (LOGGER.isLoggable(Level.FINEST)) {
-            LOGGER.log(Level.FINEST, "Moved pending as file: {0}",
+            LOGGER.log(Level.FINEST, "Moved pending as file: ''{0}''",
                 ren.target);
         }
     }
@@ -411,13 +411,13 @@ private void doLink(PendingSymlinkageExec lnk) throws IOException {
             // there is no need to worry.
             return;
         } catch (IOException e) {
-            LOGGER.log(Level.WARNING, "Failed to link: {0} -> {1}",
+            LOGGER.log(Level.WARNING, "Failed to link: ''{0}'' -> ''{1}''",
                     new Object[]{lnk.source, lnk.targetRel});
             throw e;
         }
 
         if (LOGGER.isLoggable(Level.FINEST)) {
-            LOGGER.log(Level.FINEST, "Linked pending: {0} -> {1}",
+            LOGGER.log(Level.FINEST, "Linked pending: ''{0}'' -> ''{1}''",
                     new Object[]{lnk.source, lnk.targetRel});
         }
     }
@@ -499,7 +499,7 @@ private void tryDeleteParents(List<PendingFileDeletionExec> dels) {
 
     private void tryDeleteDirectory(File dir) {
         if (dir.delete()) {
-            LOGGER.log(Level.FINE, "Removed empty parent dir: {0}",
+            LOGGER.log(Level.FINE, "Removed empty parent directory: ''{0}''",
                 dir.getAbsolutePath());
         }
     }
@@ -525,7 +525,7 @@ private void findFilelessChildren(SkeletonDirs skels, File directory) {
                     if (!didLogFileTopLevelIneligible && LOGGER.isLoggable(
                         Level.FINEST)) {
                         didLogFileTopLevelIneligible = true; // just once is OK
-                        LOGGER.log(Level.FINEST, "not file-less due to: {0}",
+                        LOGGER.log(Level.FINEST, "not file-less due to: ''{0}''",
                             f.getAbsolutePath());
                     }
                 } else {
@@ -536,7 +536,7 @@ private void findFilelessChildren(SkeletonDirs skels, File directory) {
                         topLevelIneligible = true;
                         if (LOGGER.isLoggable(Level.FINEST)) {
                             LOGGER.log(Level.FINEST,
-                                "its children prevent delete: {0}",
+                                "its children prevent delete: ''{0}''",
                                 f.getAbsolutePath());
                         }
                     }
@@ -549,8 +549,7 @@ private void findFilelessChildren(SkeletonDirs skels, File directory) {
         } catch (IOException ex) {
             topLevelIneligible = true;
             if (LOGGER.isLoggable(Level.FINEST)) {
-                LOGGER.log(Level.FINEST, "Failed to stream directory:" +
-                    directory, ex);
+                LOGGER.log(Level.FINEST, String.format("Failed to stream directory '%s'", directory), ex);
             }
         }