Sonar Code Smell issue fixes (#4455)

Signed-off-by: Gino Augustine <[email protected]>

Author: ginoaugustine

opengrok-indexer/src/main/java/org/opengrok/indexer/Info.java

@@ -31,7 +31,6 @@
  *
  * @author Trond Norbye
  */
-@SuppressWarnings("PMD.AvoidThrowingRawExceptionTypes")
 public final class Info {
     private static final Properties properties = new Properties();
 
@@ -50,7 +49,7 @@ public final class Info {
             REVISION = properties.getProperty("changeset", UNKNOWN);
             REVISION_SHORT = properties.getProperty("changeset_short", UNKNOWN);
         } catch (IOException ioe) {
-            throw new RuntimeException(ioe);
+            throw new VersionInfoLoadException(ioe);
         }
     }
 

opengrok-indexer/src/main/java/org/opengrok/indexer/VersionInfoLoadException.java

@@ -0,0 +1,50 @@
+/*
+ * CDDL HEADER START
+ *
+ * The contents of this file are subject to the terms of the
+ * Common Development and Distribution License (the "License").
+ * You may not use this file except in compliance with the License.
+ *
+ * See LICENSE.txt included in this distribution for the specific
+ * language governing permissions and limitations under the License.
+ *
+ * When distributing Covered Code, include this CDDL HEADER in each
+ * file and include the License file at LICENSE.txt.
+ * If applicable, add the following below this CDDL HEADER, with the
+ * fields enclosed by brackets "[]" replaced with your own identifying
+ * information: Portions Copyright [yyyy] [name of copyright owner]
+ *
+ * CDDL HEADER END
+ */
+
+/*
+ * Copyright (c) 2023, Oracle and/or its affiliates.
+ * Portions Copyright (c) 2023, Gino Augustine <[email protected]>.
+ */
+package org.opengrok.indexer;
+
+/**
+ * Runtime exception thrown if there is any error in loading opengrok version information file.
+ *
+ * @author Gino Augustine
+ */
+public class VersionInfoLoadException extends RuntimeException {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * Constructs a VersionInfoLoadException with the specified cause and a
+     * detail message of {@code (cause==null ? null : cause.toString())}
+     * (which typically contains the class and detail message of
+     * {@code cause}).  This constructor is useful for runtime exceptions
+     * that are little more than wrappers for other throwables.
+     *
+     * @param cause the cause (which is saved for later retrieval by the
+     *              {@link #getCause()} method).  (A {@code null} value is
+     *              permitted, and indicates that the cause is nonexistent or
+     *              unknown.)
+     * @since 1.4
+     */
+    public VersionInfoLoadException(Throwable cause) {
+        super(cause);
+    }
+}

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/ada/AdaAnalyzer.java

@@ -36,6 +36,7 @@
  * <p>
  * http://www.adaic.org/
  */
+@SuppressWarnings("java:S110")
 public class AdaAnalyzer extends AbstractSourceCodeAnalyzer {
 
     /**

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/ada/AdaLexer.java

@@ -46,7 +46,8 @@ public void takeLiteral(String value, String className)
 
         int off = 0;
         do {
-            int w = 1, i;
+            int w = 1;
+            int i;
             int ri = value.indexOf("\r", off);
             int ni = value.indexOf("\n", off);
             if (ri == -1 && ni == -1) {

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/archive/BZip2Analyzer.java

@@ -27,6 +27,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Writer;
+import java.util.Optional;
+
 import org.apache.lucene.document.Document;
 import org.apache.lucene.document.Field;
 import org.apache.tools.bzip2.CBZip2InputStream;
@@ -81,22 +83,21 @@ protected int getSpecializedVersionNo() {
     @Override
     public void analyze(Document doc, StreamSource src, Writer xrefOut)
             throws IOException, InterruptedException {
-        AbstractAnalyzer fa;
 
-        StreamSource bzSrc = wrap(src);
-        String path = doc.get(QueryBuilder.PATH);
-        if (path != null
-                && (path.endsWith(".bz2") || path.endsWith(".BZ2") || path.endsWith(".bz"))) {
-            String newname = path.substring(0, path.lastIndexOf('.'));
+        var optionalNewName = Optional.ofNullable(doc.get(QueryBuilder.PATH))
+                .filter(path -> path.toUpperCase().endsWith(".BZ2") || path.endsWith(".bz"))
+                .map(path -> path.substring(0, path.lastIndexOf('.')));
+        if (optionalNewName.isPresent()) {
+            StreamSource bzSrc = wrap(src);
+            AbstractAnalyzer fa;
             try (InputStream in = bzSrc.getStream()) {
-                fa = AnalyzerGuru.getAnalyzer(in, newname);
+                fa = AnalyzerGuru.getAnalyzer(in, optionalNewName.get());
             }
             if (!(fa instanceof BZip2Analyzer)) {
-                if (fa.getGenre() == Genre.PLAIN || fa.getGenre() == Genre.XREFABLE) {
-                    this.g = Genre.XREFABLE;
-                } else {
-                    this.g = Genre.DATA;
-                }
+                this.g = Optional.ofNullable(fa.getGenre())
+                        .filter( genre -> genre == Genre.PLAIN || genre == Genre.XREFABLE)
+                        .map(genre -> Genre.XREFABLE)
+                        .orElse(Genre.DATA);
                 fa.analyze(doc, bzSrc, xrefOut);
                 if (doc.get(QueryBuilder.T) != null) {
                     doc.removeField(QueryBuilder.T);

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/asm/AsmAnalyzer.java

@@ -33,6 +33,7 @@
 /**
  * Represents an analyzer for assembly language.
  */
+@SuppressWarnings("java:S110")
 public class AsmAnalyzer extends AbstractSourceCodeAnalyzer {
 
     /**

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/c/CAnalyzer.java

@@ -37,6 +37,7 @@
  *
  * @author Chandan
  */
+@SuppressWarnings("java:S110")
 public class CAnalyzer extends AbstractSourceCodeAnalyzer {
 
     /**

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/c/CxxAnalyzer.java

@@ -35,6 +35,7 @@
  *
  * @author Trond Norbye
  */
+@SuppressWarnings("java:S110")
 public class CxxAnalyzer extends AbstractSourceCodeAnalyzer {
 
     /**

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/clojure/ClojureAnalyzer.java

@@ -30,6 +30,7 @@
 import org.opengrok.indexer.analysis.JFlexXref;
 import org.opengrok.indexer.analysis.plain.AbstractSourceCodeAnalyzer;
 
+@SuppressWarnings("java:S110")
 public class ClojureAnalyzer extends AbstractSourceCodeAnalyzer {
 
     protected ClojureAnalyzer(AnalyzerFactory factory) {

opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/csharp/CSharpAnalyzer.java

@@ -34,6 +34,7 @@
  *
  * @author Christoph Hofmann
  */
+@SuppressWarnings("java:S110")
 public class CSharpAnalyzer extends AbstractSourceCodeAnalyzer {
 
     protected CSharpAnalyzer(AnalyzerFactory factory) {