be more careful with the patterns

vladak · vladak · commit a53af66b83fe · 2022-12-01T10:21:57.000+01:00
diff --git a/opengrok-web/src/main/webapp/history.jsp b/opengrok-web/src/main/webapp/history.jsp
@@ -374,10 +374,10 @@ document.domReady.push(function() {domReadyHistory();});
                     showSummary = true;
                     coutSummary = coutSummary.substring(0, summaryLength - 1);
                     coutSummary = Util.htmlize(coutSummary);
-                    if (bugPage != null && bugPage.length() > 0) {
+                    if (bugPage != null && bugPage.length() > 0 && bugPattern != null) {
                         coutSummary = Util.linkifyPattern(coutSummary, bugPattern, "$1", Util.completeUrl(bugPage + "$1", request));
                     }
-                    if (reviewPage != null && reviewPage.length() > 0) {
+                    if (reviewPage != null && reviewPage.length() > 0 && reviewPattern != null) {
                         coutSummary = Util.linkifyPattern(coutSummary, reviewPattern, "$1", Util.completeUrl(reviewPage + "$1", request));
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -374,10 +374,10 @@ document.domReady.push(function() {domReadyHistory();});`
`374`	`374`	`showSummary = true;`
`375`	`375`	`coutSummary = coutSummary.substring(0, summaryLength - 1);`
`376`	`376`	`coutSummary = Util.htmlize(coutSummary);`
`377`		`- if (bugPage != null && bugPage.length() > 0) {`
	`377`	`+ if (bugPage != null && bugPage.length() > 0 && bugPattern != null) {`
`378`	`378`	`coutSummary = Util.linkifyPattern(coutSummary, bugPattern, "$1", Util.completeUrl(bugPage + "$1", request));`
`379`	`379`	`}`
`380`		`- if (reviewPage != null && reviewPage.length() > 0) {`
	`380`	`+ if (reviewPage != null && reviewPage.length() > 0 && reviewPattern != null) {`
`381`	`381`	`coutSummary = Util.linkifyPattern(coutSummary, reviewPattern, "$1", Util.completeUrl(reviewPage + "$1", request));`
`382`	`382`	`}`
`383`	`383`	`}`