Skip to content

Commit a734884

Browse files
ahornaceVladimir Kotal
authored andcommitted
Improve logs when suggester data could not be created
1 parent b1d98e1 commit a734884

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/org/opensolaris/opengrok/web/api/v1/suggester/provider/service/impl/SuggesterServiceImpl.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,10 @@ public void refresh(final String project) {
184184
project);
185185
return;
186186
}
187+
if (!p.isIndexed()) {
188+
logger.log(Level.WARNING, "Cannot refresh project {0} because it is not indexed yet", project);
189+
return;
190+
}
187191
lock.readLock().lock();
188192
try {
189193
if (suggester == null) {

suggester/src/main/java/org/opengrok/suggest/SuggesterProjectData.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,9 @@ private void initFields(final Set<String> fields) throws IOException {
119119
} else if (!indexedFields.containsAll(fields)) {
120120
Set<String> copy = new HashSet<>(fields);
121121
copy.removeAll(indexedFields);
122-
logger.log(Level.WARNING, "Fields {0} will be ignored because they are not indexed", copy);
122+
logger.log(Level.WARNING,
123+
"Fields {0} will be ignored because they were not found in index directory {1}",
124+
new Object[] {copy, indexDir});
123125

124126
copy = new HashSet<>(fields);
125127
copy.retainAll(indexedFields);
@@ -346,7 +348,7 @@ public List<Lookup.LookupResult> lookup(final String field, final String prefix,
346348
try {
347349
WFSTCompletionLookup lookup = lookups.get(field);
348350
if (lookup == null) {
349-
logger.log(Level.WARNING, "No WFST for field {0}", field);
351+
logger.log(Level.WARNING, "No WFST for field {0} in {1}", new Object[] {field, suggesterDir});
350352
return Collections.emptyList();
351353
}
352354
return lookup.lookup(prefix, false, resultSize);

0 commit comments

Comments
 (0)