Skip to content

Commit a7a22da

Browse files
author
Vladimir Kotal
committed
avoid logging.basicConfig()
1 parent cdf5698 commit a7a22da

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

opengrok-tools/src/main/python/opengrok_tools/config_merge.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
from .utils.java import Java, get_javaparser
2929

30+
3031
"""
3132
Wrapper for Java program merging OpenGrok configuration.
3233
"""
@@ -39,12 +40,13 @@ def main():
3940

4041
args = parser.parse_args()
4142

43+
# Avoid using utils.log.get_console_level() since the stdout of the program
44+
# is interpreted as data.
45+
loglevel = logging.INFO
4246
if args.debug:
43-
logging.basicConfig(level=logging.DEBUG)
44-
else:
45-
logging.basicConfig()
46-
47+
loglevel = logging.DEBUG
4748
logger = logging.getLogger(__name__)
49+
logger.setLevel(loglevel)
4850

4951
cmd = Java(args.options, classpath=args.jar, java=args.java,
5052
java_opts=args.java_opts, redirect_stderr=False,

opengrok-tools/src/main/python/opengrok_tools/groups.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@
2323

2424
import argparse
2525
import logging
26-
import os
2726
import sys
2827

2928
from .utils.java import Java, get_javaparser
29+
from .utils.log import get_console_logger
30+
3031

3132
"""
3233
Script for manipulating project groups
@@ -40,12 +41,10 @@ def main():
4041

4142
args = parser.parse_args()
4243

44+
loglevel = logging.INFO
4345
if args.debug:
44-
logging.basicConfig(level=logging.DEBUG)
45-
else:
46-
logging.basicConfig()
47-
48-
logger = logging.getLogger(__name__)
46+
loglevel = logging.DEBUG
47+
logger = get_console_logger(__name__, loglevel)
4948

5049
cmd = Java(args.options, classpath=args.jar, java=args.java,
5150
java_opts=args.java_opts, redirect_stderr=False,

opengrok-tools/src/main/python/opengrok_tools/utils/command.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def __init__(self, cmd, args_subst=None, args_append=None, logger=None,
6565
self.doprint = doprint
6666

6767
self.logger = logger or logging.getLogger(__name__)
68-
logging.basicConfig()
6968

7069
if args_subst or args_append:
7170
self.fill_arg(args_append, args_subst)

0 commit comments

Comments
 (0)