check command state before accessing return value

vladak · vladak · commit aedd648db7cf · 2025-01-02T13:48:24.000+01:00
diff --git a/tools/src/main/python/opengrok_tools/scm/mercurial.py b/tools/src/main/python/opengrok_tools/scm/mercurial.py
@@ -157,7 +157,7 @@ def strip_outgoing(self):
         # If the 'hg out' command fails for some reason, it will return 255.
         # Hence, check for positive value as bail out indication.
         #
-        if status > 0:
+        if cmd.getstate() != Command.FINISHED or status > 0:
             return False
 
         revisions = list(filter(None, cmd.getoutputstr().split("\n")))

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ def strip_outgoing(self):`
`157`	`157`	`# If the 'hg out' command fails for some reason, it will return 255.`
`158`	`158`	`# Hence, check for positive value as bail out indication.`
`159`	`159`	`#`
`160`		`- if status > 0:`
	`160`	`+ if cmd.getstate() != Command.FINISHED or status > 0:`
`161`	`161`	`return False`
`162`	`162`
`163`	`163`	`revisions = list(filter(None, cmd.getoutputstr().split("\n")))`