move isAlphanumeric() to org.opensolaris.opengrok.util

Author: Vladimir Kotal

plugins/LdapPlugin/src/opengrok/auth/plugin/LdapUserPlugin.java

@@ -33,6 +33,7 @@
 import opengrok.auth.plugin.entity.User;
 import org.opensolaris.opengrok.configuration.Group;
 import org.opensolaris.opengrok.configuration.Project;
+import org.opensolaris.opengrok.util.StringUtils;
 
 /**
  * Authorization plug-in to extract user's LDAP attributes.
@@ -49,17 +50,6 @@ public class LdapUserPlugin extends AbstractLdapPlugin {
     private String objectClass;
     private final Pattern usernameCnPattern = Pattern.compile("(cn=[a-zA-Z0-9_-]+)");
 
-    private boolean isAlphanumeric(String str) {
-        for (int i = 0; i < str.length(); i++) {
-            char c = str.charAt(i);
-            if (!Character.isDigit(c) && !Character.isLetter(c)) {
-                return false;
-            }
-        }
-
-        return true;
-    }
-    
     @Override
     public void load(Map<String, Object> parameters) {
         super.load(parameters);
@@ -69,7 +59,7 @@ public void load(Map<String, Object> parameters) {
                     "] in the setup");
         }
 
-        if (!isAlphanumeric(objectClass)) {
+        if (!StringUtils.isAlphanumeric(objectClass)) {
             throw new NullPointerException("object class '" + objectClass +
                     "' contains non-alphanumeric characters");
         }

src/org/opensolaris/opengrok/util/StringUtils.java

@@ -225,4 +225,20 @@ public static int countURIEndingPushback(String value) {
         }
         return n;
     }
+    
+    /**
+     * Find out if string contains only alphanumeric characters.
+     * @param str string to check
+     * @return {@code true} if the string is alphanumeric, {@code false} otherwise
+     */
+    public static boolean isAlphanumeric(String str) {
+        for (int i = 0; i < str.length(); i++) {
+            char c = str.charAt(i);
+            if (!Character.isDigit(c) && !Character.isLetter(c)) {
+                return false;
+            }
+        }
+
+        return true;
+    }
 }

test/org/opensolaris/opengrok/util/StringUtilsTest.java

@@ -17,11 +17,12 @@
  * CDDL HEADER END
  */
 
- /*
+/*
  * Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
  */
 package org.opensolaris.opengrok.util;
 
+import org.junit.Assert;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
@@ -129,4 +130,10 @@ public void uriEmptyShouldNotCountAnyPushback() {
         int n = StringUtils.countURIEndingPushback(uri);
         assertEquals("empty pushback", 0, n);
     }
+    
+    @Test
+    public void testIsAlphanumeric() {
+        Assert.assertTrue(StringUtils.isAlphanumeric("foo123"));
+        Assert.assertFalse(StringUtils.isAlphanumeric("foo_123"));
+    }
 }