Skip to content

Commit b7bbebc

Browse files
ahornaceVladimir Kotal
authored andcommitted
Do not throw exception when incrementing search count of unknown term
1 parent 6c3ba2d commit b7bbebc

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

suggester/src/main/java/org/opengrok/suggest/FieldWFSTCollection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ public void incrementSearchCount(final Term term, final int value) {
370370
lock.readLock().lock();
371371
try {
372372
if (lookups.get(term.field()).get(term.text()) == null) {
373-
throw new IllegalArgumentException("Unknown term " + term);
373+
return; // unknown term
374374
}
375375

376376
PopularityMap map = searchCountMaps.get(term.field());

suggester/src/test/java/org/opengrok/suggest/FieldWFSTCollectionTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -200,15 +200,6 @@ public void incrementByNegativeValueTest() throws IOException {
200200
f.incrementSearchCount(new Term("test", "example"), -10);
201201
}
202202

203-
@Test(expected = IllegalArgumentException.class)
204-
public void incrementUnknownTermTest() throws IOException {
205-
addText("test", "test case document");
206-
207-
init(true);
208-
209-
f.incrementSearchCount(new Term("test", "unknown"));
210-
}
211-
212203
@Test
213204
public void rebuildRemoveOldTermsTest() throws IOException {
214205
addText("test", "term");

0 commit comments

Comments
 (0)