Download junit and hamcrest jar files automatically by ant.

hamcrest is a dependency for junit, so check that first.
Fix also README.md instructions.

Author: ivosh

.gitignore

@@ -32,6 +32,7 @@ lib/jrcs.jar
 lib/lucene-*
 lib/servlet-api-*
 lib/junit-*
+lib/hamcrest-core-*
 derby.log
 opengrok*.log
 nbproject/genfiles.properties

README.md

@@ -684,16 +684,16 @@ being executed on) under the `dist/` directory.
 
 ### 8.1 Unit testing
 
-**Note**: For full coverage report your system has to provide proper junit test
-environment, that would mean:
+**Note**: For full coverage report, a proper junit test environment is required.
+That would mean:
 
-  * you have to use Ant 1.9 and above
-  * at least `junit-4.12.jar` has to be in ant's classpath (e.g. in `./lib`)
-
-  * your `PATH` must contain directory with exuberant ctags binary
+  * You have to use Ant 1.9 and above
+  * At least `junit-4.12.jar` and its dependencies have to be in ant's
+    classpath (e.g. in `./lib`). The test task will download them automatically.
+  * Your `PATH` must contain directory with exuberant ctags binary
     * **Note**: make sure that the directory which contains exuberant ctags binary
       is prepended before the directory with plain ctags program.
-  * your `PATH` variable must contain directories which contain binaries of
+  * Your `PATH` variable must contain directories which contain binaries of
     appropriate SCM software which means commands hg, sccs, cvs, git, bzr, svn
     (svnadmin too). They must be available for the full report.
 

build.xml

@@ -119,6 +119,8 @@ Portions Copyright (c) 2017, Chris Fraire <[email protected]>.
 
     <property name="junit.version" value="4.12"/>
     <property name="junit.jar" value="junit-${junit.version}.jar"/>
+    <property name="hamcrest.version" value="1.3"/>
+    <property name="hamcrest.jar" value="hamcrest-core-${hamcrest.version}.jar"/>
 
     <property name="mvn.repository" value="http://repo1.maven.org/maven2"/>
 
@@ -565,7 +567,7 @@ Portions Copyright (c) 2017, Chris Fraire <[email protected]>.
         </condition>
     </target>
 
-    <target name="download-junit" depends="-check-junit" if="junit_not_downloaded">
+    <target name="download-junit" depends="-check-junit,download-hamcrest" if="junit_not_downloaded">
         <delete>
             <fileset dir="lib">
                 <include name="junit-*.jar"/>
@@ -575,6 +577,27 @@ Portions Copyright (c) 2017, Chris Fraire <[email protected]>.
              dest="lib/${junit.jar}" verbose="true" usetimestamp="true"/>
     </target>
 
+    <target name="-check-hamcrest" description="Check that hamcrest jar file is present">
+        <available file="${hamcrest.jar}" type="file" property="hamcrest.jar.present">
+            <filepath refid="plainlib.search.path"/>
+        </available>
+        <condition property="hamcrest_not_downloaded">
+            <not>
+                <isset property="hamcrest.jar.present"/>
+            </not>
+        </condition>
+    </target>
+
+    <target name="download-hamcrest" depends="-check-hamcrest" if="hamcrest_not_downloaded">
+        <delete>
+            <fileset dir="lib">
+                <include name="hamcrest-*.jar"/>
+            </fileset>
+        </delete>
+        <get src="${mvn.repository}/org/hamcrest/hamcrest-core/${hamcrest.version}/${hamcrest.jar}"
+             dest="lib/${hamcrest.jar}" verbose="true" usetimestamp="true"/>
+    </target>
+
     <target name="-post-jar" depends="-copy-lib-without-netbeans">
         <war destfile="${dist.war}" webxml="web/WEB-INF/web.xml">
             <fileset dir="web" excludes="META-INF/context.xml"/>
@@ -863,7 +886,7 @@ Portions Copyright (c) 2017, Chris Fraire <[email protected]>.
         </jacoco:report>
     </target>
 
-    <target name="-pre-compile-test" depends="-check-junit"><!-- depends="-set-jacocoagent"> -->
+    <target name="-pre-compile-test" depends="download-junit"><!-- depends="-set-jacocoagent"> -->
     </target>
 
     <!-- <target name="-pre-compile-test-single" depends="-set-jacocoagent"/> -->