Opengrok tools use pytest instead of unittest (#2504)

Author: tulinkry

opengrok-tools/pom.xml

@@ -145,6 +145,7 @@ Portions Copyright (c) 2017-2018, Chris Fraire <[email protected]>.
                                         <include>MANIFEST.in</include>
                                         <include>README.md</include>
                                         <include>setup.py</include>
+                                        <include>setup.cfg</include>
                                     </includes>
                                 </resource>
                             </resources>
@@ -203,6 +204,7 @@ Portions Copyright (c) 2017-2018, Chris Fraire <[email protected]>.
                                 <argument>install</argument>
                                 <argument>--upgrade</argument>
                                 <argument>pip</argument>
+                                <argument>setuptools</argument>
                             </arguments>
                         </configuration>
                         <phase>test</phase>

opengrok-tools/setup.cfg

@@ -0,0 +1,6 @@
+[aliases]
+test=pytest
+
+[tool:pytest]
+addopts = -v --color=yes
+testpaths = src/test/python

opengrok-tools/setup.py

@@ -45,10 +45,15 @@ def my_test_suite():
         'pyyaml',
         'requests>=2.20.0',
         'resource',
-        'filelock'
+        'filelock',
+        'setuptools>=36.7.2',
+    ],
+    setup_requires=[
+        'pytest-runner',
+        'setuptools>=36.7.2',
     ],
     tests_require=[
-        'parameterized'
+        'pytest',
     ],
     entry_points={
         'console_scripts': [

opengrok-tools/src/test/python/test_binaries.py

@@ -23,39 +23,31 @@
 # Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
 #
 
-import unittest
-
-from parameterized import parameterized
+import pytest
 
 from opengrok_tools.utils.command import Command
 
 
-class TestApp(unittest.TestCase):
-    @parameterized.expand((
-            ('opengrok'),
-            ('opengrok-indexer'),
-            ('opengrok-groups'),
-            ('opengrok-config-merge'),
-            ('opengrok-deploy'),
-            ('opengrok-java'),
-            ('opengrok-mirror'),
-            ('opengrok-projadm'),
-            ('opengrok-reindex-project'),
-            ('opengrok-sync'),
-    ))
-    def test_opengrok_binary(self, command):
-        """
-        Test that installed command is able to run
-        :param command: the command name
-        :return:
-        """
-        pass
-        cmd = Command([command, '--help'])
-        cmd.execute()
-        self.assertEqual(0, cmd.getretcode())
-        self.assertEqual(Command.FINISHED, cmd.getstate())
-        self.assertTrue(len(cmd.getoutputstr()) > 1)
-
-
-if __name__ == '__main__':
-    unittest.main()
+@pytest.mark.parametrize('command', (
+        ('opengrok'),
+        ('opengrok-indexer'),
+        ('opengrok-groups'),
+        ('opengrok-config-merge'),
+        ('opengrok-deploy'),
+        ('opengrok-java'),
+        ('opengrok-mirror'),
+        ('opengrok-projadm'),
+        ('opengrok-reindex-project'),
+        ('opengrok-sync'),
+))
+def test_opengrok_binary(command):
+    """
+    Test that installed command is able to run
+    :param command: the command name
+    :return:
+    """
+    cmd = Command([command, '--help'])
+    cmd.execute()
+    assert cmd.getretcode() == 0
+    assert cmd.getstate() == Command.FINISHED
+    assert len(cmd.getoutputstr()) > 1