adding basic stats for authorization decisions (#1558)

Author: tulinkry

src/org/opensolaris/opengrok/authorization/AuthorizationFramework.java

@@ -46,6 +46,7 @@
 import org.opensolaris.opengrok.configuration.RuntimeEnvironment;
 import org.opensolaris.opengrok.logger.LoggerFactory;
 import org.opensolaris.opengrok.util.IOUtils;
+import org.opensolaris.opengrok.web.Statistics;
 
 /**
  * Placeholder for performing authorization checks.
@@ -599,18 +600,38 @@ private boolean checkAll(HttpServletRequest request, String cache, Nameable enti
             return true;
         }
 
+        Statistics stats = RuntimeEnvironment.getInstance().getStatistics();
+
         Boolean val;
         Map<String, Boolean> m = (Map<String, Boolean>) request.getAttribute(cache);
 
         if (m == null) {
             m = new TreeMap<>();
         } else if ((val = m.get(entity.getName())) != null) {
             // cache hit
+            stats.addRequest(request, "authorization_cache_hits");
             return val;
         }
 
+        stats.addRequest(request, "authorization_cache_misses");
+
+        long time = System.currentTimeMillis();
+
         boolean overallDecision = performCheck(entity, predicate);
 
+        time = System.currentTimeMillis() - time;
+
+        stats.addRequestTime(request, "authorization", time);
+        stats.addRequestTime(request,
+                String.format("authorization_%s", overallDecision ? "positive" : "negative"),
+                time);
+        stats.addRequestTime(request,
+                String.format("authorization_%s_of_%s", overallDecision ? "positive" : "negative", entity.getName()),
+                time);
+        stats.addRequestTime(request,
+                String.format("authorization_of_%s", entity.getName()),
+                time);
+
         m.put(entity.getName(), overallDecision);
         request.setAttribute(cache, m);
         return overallDecision;

src/org/opensolaris/opengrok/web/Statistics.java

@@ -99,6 +99,7 @@ protected void maybeRefresh() {
     /**
      * Adds a request into the category
      *
+     * @param req the given request
      * @param category category
      */
     public void addRequest(HttpServletRequest req, String category) {
@@ -113,6 +114,7 @@ public void addRequest(HttpServletRequest req, String category) {
     /**
      * Adds a request's process time into given category.
      *
+     * @param req the given request
      * @param category category
      * @param v time spent on processing this request
      */

src/org/opensolaris/opengrok/web/StatisticsFilter.java

@@ -78,6 +78,10 @@ protected void collectStats(HttpServletRequest req, String category) {
             stats.addRequestTime(req, category, processTime); // add this category
 
             /* supplementary categories */
+            if (config.getProject() != null) {
+                stats.addRequestTime(req, "viewing_of_" + config.getProject().getName(), processTime);
+            }
+
             SearchHelper helper = (SearchHelper) config.getRequestAttribute(SearchHelper.REQUEST_ATTR);
             if (helper != null) {
                 if (helper.hits == null || helper.hits.length == 0) {