Remove a bit of old redundancy

Author: idodeclare

opengrok-indexer/src/main/java/org/opengrok/indexer/web/SearchHelper.java

@@ -45,6 +45,7 @@
 import org.apache.lucene.document.Document;
 import org.apache.lucene.index.DirectoryReader;
 import org.apache.lucene.index.IndexReader;
+import org.apache.lucene.index.IndexableField;
 import org.apache.lucene.index.Term;
 import org.apache.lucene.queryparser.classic.ParseException;
 import org.apache.lucene.search.BooleanQuery;
@@ -401,21 +402,24 @@ public SearchHelper executeQuery() {
             // one single definition term AND we have exactly one match AND there
             // is only one definition of that symbol in the document that matches.
             boolean uniqueDefinition = false;
+            Document doc = null;
+            String symbol = null;
             if (isCrossRefSearch && isSingleDefinitionSearch && hits != null && hits.length == 1) {
-                Document doc = searcher.doc(hits[0].doc);
-                if (doc.getField(QueryBuilder.TAGS) != null) {
-                    byte[] rawTags = doc.getField(QueryBuilder.TAGS).binaryValue().bytes;
+                doc = searcher.doc(hits[0].doc);
+                IndexableField tagsField = doc.getField(QueryBuilder.TAGS);
+                if (tagsField != null) {
+                    byte[] rawTags = tagsField.binaryValue().bytes;
                     Definitions tags = Definitions.deserialize(rawTags);
-                    String symbol = ((TermQuery) query).getTerm().text();
+                    symbol = ((TermQuery) query).getTerm().text();
                     if (tags.occurrences(symbol) == 1) {
                         uniqueDefinition = true;
                     }
                 }
             }
             if (uniqueDefinition) {
-                String anchor = Util.URIEncode(((TermQuery) query).getTerm().text());
+                String anchor = Util.URIEncode(symbol);
                 redirect = contextPath + Prefix.XREF_P
-                        + Util.URIEncodePath(searcher.doc(hits[0].doc).get(QueryBuilder.PATH))
+                        + Util.URIEncodePath(doc.get(QueryBuilder.PATH))
                         + '?' + QueryParameters.FRAGMENT_IDENTIFIER_PARAM_EQ + anchor
                         + '#' + anchor;
             }