treat compilation warnings as errors

fixes #2246

Author: Vladimir Kotal

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/RuntimeEnvironment.java

@@ -472,6 +472,7 @@ public List<Project> getProjectList() {
      *
      * @return a Map with all of the projects
      */
+    @SuppressWarnings("unchecked")
     public Map<String,Project> getProjects() {
         return (Map<String,Project>)getConfigurationValue("projects");
     }
@@ -516,6 +517,7 @@ public boolean hasGroups() {
      *
      * @return a set containing all of the groups (may be null)
      */
+    @SuppressWarnings("unchecked")
     public Set<Group> getGroups() {
         return (Set<Group>)getConfigurationValue("groups");
     }
@@ -723,6 +725,7 @@ public void setQuickContextScan(boolean quickContextScan) {
         setConfigurationValue("quickContextScan", quickContextScan);
     }
 
+    @SuppressWarnings("unchecked")
     public List<RepositoryInfo> getRepositories() {
         return (List<RepositoryInfo>)getConfigurationValue("repositories");
     }
@@ -790,6 +793,7 @@ public void setDefaultProjects(Set<Project> defaultProjects) {
      *
      * @return the default projects (may be null if not specified)
      */
+    @SuppressWarnings("unchecked")
     public Set<Project> getDefaultProjects() {
         Set<Project> projects = (Set<Project>)getConfigurationValue("defaultProjects");
         if (projects == null) {
@@ -1161,6 +1165,7 @@ public void setCTagsExtraOptionsFile(String filename) {
         setConfigurationValue("CTagsExtraOptionsFile", filename);
     }
 
+    @SuppressWarnings("unchecked")
     public Set<String> getAllowedSymlinks() {
         return (Set<String>)getConfigurationValue("allowedSymlinks");
     }

opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java

@@ -318,7 +318,7 @@ public static void main(String argv[]) {
             // Get history first.
             getInstance().prepareIndexer(env, searchRepositories, addProjects,
                     defaultProjects,
-                    listFiles, createDict, subFiles, new ArrayList(repositories),
+                    listFiles, createDict, subFiles, new ArrayList<>(repositories),
                     zapCache, listRepos);
             if (listRepos || !zapCache.isEmpty()) {
                 return;

opengrok-indexer/src/main/java/org/opengrok/indexer/util/ClassUtil.java

@@ -77,6 +77,7 @@ public static void remarkTransientFields(Class targetClass) {
         }
     }
 
+    @SuppressWarnings("unchecked")
     private static Object stringToObject(String fieldName, Class c, String value) throws IOException {
         Object v;
         String paramClass = c.getName();

opengrok-web/src/main/java/org/opengrok/web/api/v1/suggester/query/SuggesterQueryParser.java

@@ -230,6 +230,7 @@ protected Query newFuzzyQuery(final Term term, final float minimumSimilarity, fi
                 replaceIdentifier(term.field(), term.text() + "~" + ((int) minimumSimilarity));
             }
 
+            @SuppressWarnings("deprecation")
             int numEdits = FuzzyQuery.floatToEdits(minimumSimilarity,
                     newTerm.text().codePointCount(0, newTerm.text().length()));
 

pom.xml

@@ -198,6 +198,10 @@ Portions Copyright (c) 2018, Chris Fraire <[email protected]>.
                     <source>${compileSource}</source>
                     <target>${compileTarget}</target>
                     <encoding>${project.build.sourceEncoding}</encoding>
+                    <compilerArgs>
+                      <arg>-Xlint:all</arg>
+                      <arg>-Werror</arg>
+                    </compilerArgs>
                 </configuration>
                 <version>3.6.1</version>
             </plugin>