Skip to content

Commit c6e1154

Browse files
author
Vladimir Kotal
committed
read and send configuration as UTF-8
fix noop handling
1 parent 3f61e1c commit c6e1154

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

tools/projadm.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import logging
3838
import tempfile
3939
import shutil
40+
import io
4041
from utils import get_command
4142
from opengrok import get_configuration, set_configuration, add_project, \
4243
delete_project, get_config_value
@@ -207,7 +208,7 @@ def project_delete(doit, logger, project, uri):
207208
help='path to the ConfigMerge binary')
208209
parser.add_argument('-u', '--upload', action='store_true',
209210
help='Upload configuration at the end')
210-
parser.add_argument('-n', '--noop', action='store_false', default=True,
211+
parser.add_argument('-n', '--noop', action='store_true', default=False,
211212
help='Do not run any commands or modify any config'
212213
', just report. Usually implies the --debug option.')
213214

@@ -223,6 +224,7 @@ def project_delete(doit, logger, project, uri):
223224
'configuration.')
224225

225226
args = parser.parse_args()
227+
doit = not args.noop
226228

227229
#
228230
# Setup logger as a first thing after parsing arguments so that it can be
@@ -271,28 +273,28 @@ def project_delete(doit, logger, project, uri):
271273
with lock.acquire(timeout=0):
272274
if args.add:
273275
for proj in args.add:
274-
project_add(doit=args.noop, logger=logger,
276+
project_add(doit=doit, logger=logger,
275277
project=proj,
276278
uri=uri)
277279

278-
config_refresh(doit=args.noop, logger=logger,
280+
config_refresh(doit=doit, logger=logger,
279281
basedir=args.base,
280282
uri=uri,
281283
configmerge=configmerge_file,
282284
roconfig=args.roconfig)
283285
elif args.delete:
284286
for proj in args.delete:
285-
project_delete(doit=args.noop, logger=logger,
287+
project_delete(doit=doit, logger=logger,
286288
project=proj,
287289
uri=uri)
288290

289-
config_refresh(doit=args.noop, logger=logger,
291+
config_refresh(doit=doit, logger=logger,
290292
basedir=args.base,
291293
uri=uri,
292294
configmerge=configmerge_file,
293295
roconfig=args.roconfig)
294296
elif args.refresh:
295-
config_refresh(doit=args.noop, logger=logger,
297+
config_refresh(doit=doit, logger=logger,
296298
basedir=args.base,
297299
uri=uri,
298300
configmerge=configmerge_file,
@@ -304,9 +306,12 @@ def project_delete(doit, logger, project, uri):
304306
if args.upload:
305307
main_config = get_config_file(basedir=args.base)
306308
if path.isfile(main_config):
307-
if args.noop:
308-
set_configuration(logger, main_config, uri)
309-
309+
if doit:
310+
with io.open(main_config, mode='r',
311+
encoding="utf-8") as config_file:
312+
config_data = config_file.read()
313+
set_configuration(logger,
314+
config_data.encode("utf-8"), uri)
310315
else:
311316
logger.error("file {} does not exist".format(main_config))
312317
sys.exit(1)

0 commit comments

Comments
 (0)