add hasField() to detect property in a class instance

also fix wrong repository field value propagation

Author: Vladimir Kotal

opengrok-indexer/src/main/java/org/opengrok/indexer/util/ClassUtil.java

@@ -224,6 +224,20 @@ private static void invokeSetter(Method setter, Object obj, String fieldName, Ob
         }
     }
 
+    /**
+     * @param obj object
+     * @param fieldName field name
+     * @return true if field is present in the object (not recursively) or false
+     */
+    public static boolean hasField(Object obj, String fieldName) {
+        try {
+            PropertyDescriptor desc = new PropertyDescriptor(fieldName, obj.getClass());
+        } catch (IntrospectionException e) {
+            return false;
+        }
+        return true;
+    }
+
     /**
      * Invokes a getter of a property on an object.
      *

opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/ProjectsController.java

@@ -315,17 +315,10 @@ public void set(
             List<RepositoryInfo> riList = env.getProjectRepositoriesMap().get(project);
             if (riList != null) {
                 for (RepositoryInfo ri : riList) {
-                    Repository repo = getRepository(ri, CommandTimeoutType.RESTFUL);
-
                     // Set the property if there is one.
-                    try {
-                        ClassUtil.getFieldValue(repo, field);
-                    } catch (IOException e) {
-                        // ignore
-                        continue;
+                    if (ClassUtil.hasField(ri, field)) {
+                        ClassUtil.setFieldValue(ri, field, value);
                     }
-
-                    ClassUtil.setFieldValue(repo, field, value);
                 }
             }
         } else {

opengrok-web/src/test/java/org/opengrok/web/api/v1/controller/ProjectsControllerTest.java

@@ -482,21 +482,24 @@ void testGetRepos() throws Exception {
     }
 
     @Test
-    void testSetIndexed() throws Exception {
+    void testSetIndexed() {
         String project = "git";
         addProject(project);
         assertEquals(1, env.getProjectList().size());
 
+        env.getProjects().get(project).setIndexed(false);
+        assertFalse(env.getProjects().get(project).isIndexed());
         Response response = target("projects")
                 .path(project)
                 .path("property/indexed")
                 .request()
                 .put(Entity.text(Boolean.TRUE.toString()));
         assertEquals(response.getStatus(), Response.Status.NO_CONTENT.getStatusCode());
+        assertTrue(env.getProjects().get(project).isIndexed());
     }
 
     @Test
-    void testSetGet() throws Exception {
+    void testSetGet() {
         assertTrue(env.isHandleHistoryOfRenamedFiles());
         String[] projects = new String[] {"mercurial", "git"};
 
@@ -505,8 +508,19 @@ void testSetGet() throws Exception {
         }
 
         assertEquals(2, env.getProjectList().size());
+        for (String proj : projects) {
+            Project project = env.getProjects().get(proj);
+            assertNotNull(project);
+            assertTrue(project.isHandleRenamedFiles());
+            List<RepositoryInfo> riList = env.getProjectRepositoriesMap().get(project);
+            assertNotNull(riList);
+            for (RepositoryInfo ri : riList) {
+                ri.setHandleRenamedFiles(true);
+                assertTrue(ri.isHandleRenamedFiles());
+            }
+        }
 
-        // Change their property.
+        // Change their property via RESTful API call.
         for (String proj : projects) {
             setHandleRenamedFilesToFalse(proj);
         }
@@ -519,8 +533,7 @@ void testSetGet() throws Exception {
             List<RepositoryInfo> riList = env.getProjectRepositoriesMap().get(project);
             assertNotNull(riList);
             for (RepositoryInfo ri : riList) {
-                Repository repo = getRepository(ri, CommandTimeoutType.RESTFUL);
-                assertFalse(repo.isHandleRenamedFiles());
+                assertFalse(ri.isHandleRenamedFiles());
             }
         }