fix units for the connect timeout (#4228)

Author: vladak

opengrok-indexer/src/main/java/org/opengrok/indexer/util/HostUtil.java

@@ -59,10 +59,10 @@ public static int urlToPort(String urlStr) throws URISyntaxException {
         return uri.getPort();
     }
 
-    private static boolean isWebAppReachable(String webappURI, int timeOutMillis, @Nullable String token) {
+    private static boolean isWebAppReachable(String webappURI, int timeOutSeconds, @Nullable String token) {
         ClientBuilder clientBuilder = ClientBuilder.newBuilder();
-        clientBuilder.connectTimeout(timeOutMillis, TimeUnit.MILLISECONDS);
-        clientBuilder.readTimeout(timeOutMillis, TimeUnit.MILLISECONDS);
+        clientBuilder.connectTimeout(timeOutSeconds, TimeUnit.SECONDS);
+        clientBuilder.readTimeout(timeOutSeconds, TimeUnit.SECONDS);
 
         // Here, IndexerUtil#getWebAppHeaders() is not used because at the point this method is called,
         // the RuntimeEnvironment configuration used by getWebAppHeaders() is not set yet.
@@ -71,6 +71,8 @@ private static boolean isWebAppReachable(String webappURI, int timeOutMillis, @N
             headers.add(HttpHeaders.AUTHORIZATION, "Bearer " + token);
         }
 
+        LOGGER.log(Level.FINE, "checking reachability of {0} with connect/read timeout of {1} seconds",
+                new Object[]{webappURI, timeOutSeconds});
         try (Client client = clientBuilder.build()) {
             Response response = client
                 .target(webappURI)
@@ -97,11 +99,11 @@ private static boolean isWebAppReachable(String webappURI, int timeOutMillis, @N
     /**
      *
      * @param webappURI URI of the web app
-     * @param timeOutMillis connect/read timeout in milliseconds
+     * @param timeOutSeconds connect/read timeout in seconds
      * @param token authentication token, can be {@code null}
      * @return whether web app is reachable within given timeout on given URI
      */
-    public static boolean isReachable(String webappURI, int timeOutMillis, @Nullable String token) {
+    public static boolean isReachable(String webappURI, int timeOutSeconds, @Nullable String token) {
         boolean connectWorks = false;
 
         try {
@@ -111,7 +113,7 @@ public static boolean isReachable(String webappURI, int timeOutMillis, @Nullable
                 return false;
             }
 
-            return isWebAppReachable(webappURI, timeOutMillis, token);
+            return isWebAppReachable(webappURI, timeOutSeconds, token);
         } catch (URISyntaxException e) {
             LOGGER.log(Level.SEVERE, String.format("URI not valid: %s", webappURI), e);
         }

opengrok-indexer/src/test/java/org/opengrok/indexer/util/HostUtilTest.java

@@ -33,21 +33,21 @@
 public class HostUtilTest {
     @Test
     void testInvalidURI() {
-        assertFalse(HostUtil.isReachable("htt://localhost:8080/source/", 1000, null));
+        assertFalse(HostUtil.isReachable("htt://localhost:8080/source/", 10, null));
     }
 
     @Test
     void testInvalidHost() {
-        assertFalse(HostUtil.isReachable("http://localhosta:8080/source/", 1000, null));
+        assertFalse(HostUtil.isReachable("http://localhosta:8080/source/", 10, null));
     }
 
     @Test
     void testInvalidPort() {
-        assertFalse(HostUtil.isReachable("http://localhost:zzzz/source/", 1000, null));
+        assertFalse(HostUtil.isReachable("http://localhost:zzzz/source/", 10, null));
     }
 
     @Test
     void testNotReachableWebApp() {
-        assertFalse(HostUtil.isReachable("http://localhost:4444/source/", 1000, null));
+        assertFalse(HostUtil.isReachable("http://localhost:4444/source/", 10, null));
     }
 }