add API to get RepositoryInfo fields

fixes #2960

Author: Vladimir Kotal

apiary.apib

@@ -238,19 +238,13 @@ will be used for repository paths.
 
             ["sc-2","sc-1"]
 
-## Repository type [/repositories/type{?repository}]
+## Repository type [/repositories/property/{field}{?repository}]
 
-### return type of the repository [GET]
+### return the field value [GET]
 
 The repository path is relative to source root.
 
-In the response the repository type is separated from the repository path
-with a colon. If the type cannot be determined "N/A" is returned.
-
-+ Response 200 (text/plain)
-  + Body
-
-            /opengrok-master:git
++ Response 200 (application/json)
 
 + Parameters
   + repository - repository path with native path separators (of the machine

opengrok-indexer/src/main/java/org/opengrok/indexer/history/RepositoryInfo.java

@@ -193,7 +193,7 @@ public boolean isWorking() {
      *
      * @param working is repository working
      */
-    public void setWorking(Boolean working) {
+    public void setWorking(boolean working) {
         this.working = working;
     }
 

opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/RepositoriesController.java

@@ -24,28 +24,45 @@
 
 import org.opengrok.indexer.configuration.RuntimeEnvironment;
 import org.opengrok.indexer.history.RepositoryInfo;
+import org.opengrok.indexer.util.ClassUtil;
 
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
 import javax.ws.rs.Produces;
 import javax.ws.rs.QueryParam;
+import javax.ws.rs.WebApplicationException;
 import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import java.io.IOException;
 
 @Path("/repositories")
 public class RepositoriesController {
 
     private RuntimeEnvironment env = RuntimeEnvironment.getInstance();
 
-    @GET
-    @Path("/type")
-    @Produces(MediaType.TEXT_PLAIN)
-    public String getType(@QueryParam("repository") final String repositoryPath) {
+    private RepositoryInfo getRepositoryInfo(String repositoryPath) {
         for (RepositoryInfo ri : env.getRepositories()) {
             if (ri.getDirectoryNameRelative().equals(repositoryPath)) {
-                return repositoryPath + ":" + ri.getType();
+                return ri;
             }
         }
-        return repositoryPath + ":N/A";
+
+        return null;
     }
 
+    @GET
+    @Path("/property/{field}")
+    @Produces(MediaType.APPLICATION_JSON)
+    public Object get(@QueryParam("repository") final String repositoryPath, @PathParam("field") final String field)
+            throws IOException {
+
+        RepositoryInfo ri = getRepositoryInfo(repositoryPath);
+        if (ri == null) {
+            throw new WebApplicationException("cannot find repository with path: " + repositoryPath,
+                    Response.Status.NOT_FOUND);
+        }
+
+        return ClassUtil.getFieldValue(ri, field);
+    }
 }

opengrok-web/src/test/java/org/opengrok/web/api/v1/controller/RepositoriesControllerTest.java

@@ -88,10 +88,9 @@ public void tearDown() throws Exception {
         repository.destroy();
     }
 
-    @Test
-    public void testGetRepositoryTypeOfNonExistenRepository() throws Exception {
-        assertEquals(Paths.get("/totally-nonexistent-repository").toString() + ":N/A",
-                getRepoType(Paths.get("/totally-nonexistent-repository").toString()));
+    @Test(expected = javax.ws.rs.NotFoundException.class)
+    public void testGetRepositoryTypeOfNonExistentRepository() throws Exception {
+        getRepoType(Paths.get("/totally-nonexistent-repository").toString());
     }
 
     @Test
@@ -111,17 +110,17 @@ public void testGetRepositoryType() throws Exception {
                 null, // subFiles - needed when refreshing history partially
                 null); // repositories - needed when refreshing history partially
 
-        assertEquals(Paths.get("/mercurial").toString() + ":Mercurial",
+        assertEquals("Mercurial",
                 getRepoType(Paths.get("/mercurial").toString()));
-        assertEquals(Paths.get("/mercurial/closed").toString() + ":Mercurial",
+        assertEquals("Mercurial",
                 getRepoType(Paths.get("/mercurial/closed").toString()));
-        assertEquals(Paths.get("/git").toString() + ":git",
+        assertEquals("git",
                 getRepoType(Paths.get("/git").toString()));
     }
 
     private String getRepoType(final String repository) {
         return target("repositories")
-                .path("type")
+                .path("property/type")
                 .queryParam("repository", repository)
                 .request()
                 .get(String.class);