disable generating full history for renamed files by default

fixes #1773

Author: vladak

OpenGrok

@@ -42,14 +42,13 @@
 #                                 through project, it's good to have Verbose
 #                                 Mode enabled too, cost of this is one more
 #                                 traversal of the project before indexing it(*)
-#   - OPENGROK_DISABLE_RENAMED_FILES_HISTORY Disable getting full history of
+#   - OPENGROK_RENAMED_FILES_HISTORY If set to "on", get full history of
 #                                 renamed files for SCMs that support it (Git,
 #                                 Mercurial).
-#                                 The default is handle the history which makes
-#                                 indexing slower, especially in the presence of
+#                                 The default is off.
+#                                 When set to on, the indexing is slower,
+#                                 especially in the presence of
 #                                 lots of renamed files in the repository.
-#                                 Set it to non-empty value to disable the
-#                                 renamed files history handling.
 #   - OPENGROK_GENERATE_HISTORY   Influence history cache generation
 #                                 Following values are recognized:
 #                                   on		- enabled (default)
@@ -286,9 +285,11 @@ DefaultInstanceConfiguration()
         GENERATE_HISTORY="${GENERATE_HISTORY} -H"
     fi
 
-    if [ -n "$OPENGROK_DISABLE_RENAMED_FILES_HISTORY" ]
+    if [ "$OPENGROK_RENAMED_FILES_HISTORY" != "on" ]
     then
-        DISABLE_RENAMED_FILES_HISTORY="-D"
+        RENAMED_FILES_HISTORY="-D off"
+    else
+        RENAMED_FILES_HISTORY="-D on"
     fi
 
     # OPTIONAL: override depth of scanning for repositories
@@ -819,7 +820,7 @@ CommonInvocation()
         ${IGNORE_PATTERNS}                    				\
         ${HISTORY_TAGS}							\
         ${GENERATE_HISTORY}           					\
-	${DISABLE_RENAMED_FILES_HISTORY}				\
+	${RENAMED_FILES_HISTORY}					\
         ${SCAN_DEPTH}                                           	\
         ${PROGRESS}                                             	\
         ${OPENGROK_CTAGS:+-c} ${OPENGROK_CTAGS}               		\

src/org/opensolaris/opengrok/configuration/Configuration.java

@@ -371,7 +371,7 @@ public Configuration() {
         setGenerateHtml(true);
         setGroups(new TreeSet<>());
         setGroupsCollapseThreshold(4);
-        setHandleHistoryOfRenamedFiles(true);
+        setHandleHistoryOfRenamedFiles(false);
         setHistoryCache(true);
         setHistoryCacheTime(30);
         setHistoryEnabled(true);

src/org/opensolaris/opengrok/index/CommandLineOptions.java

@@ -78,7 +78,7 @@ public CommandLineOptions() {
         options.add(new Option('C', null, "Print per project percentage progress information(I/O extensive, since one read through dir structure is made before indexing, needs -v, otherwise it just goes to the log)"));
         options.add(new Option('c', "/path/to/ctags", "Path to Exuberant Ctags from http://ctags.sf.net by default takes the Exuberant Ctags in PATH."));
         options.add(new Option('d', "/path/to/data/root", "The directory where OpenGrok stores the generated data"));
-        options.add(new Option('D', null, "Disable generating history for renamed files. Makes indexing faster for repositories with lots of renamed files."));
+        options.add(new Option('D', ON_OFF, "Enable or disable generating history for renamed files. If set to on, makes history indexing slower for repositories with lots of renamed files."));
         options.add(new Option('e', null, "Economical - consumes less disk space. It does not generate hyper text cross reference files offline, but will do so on demand - which could be sightly slow."));
         options.add(new Option('G', null, "Assign commit tags to all entries in history for all repositories."));
         options.add(new Option('H', null, "Get history for all repositories"));

src/org/opensolaris/opengrok/index/Indexer.java

@@ -246,7 +246,8 @@ public static void main(String argv[]) {
                             break;
                         }
                         case 'D':
-                            cfg.setHandleHistoryOfRenamedFiles(false);
+                            cfg.setHandleHistoryOfRenamedFiles(getopt.getOptarg().
+                                    equals("on"));
                             break;
                         case 'e':
                             cfg.setGenerateHtml(false);

test/org/opensolaris/opengrok/history/GitRepositoryTest.java

@@ -42,6 +42,7 @@
 import org.opensolaris.opengrok.util.TestRepository;
 
 import static org.junit.Assert.*;
+import org.opensolaris.opengrok.configuration.RuntimeEnvironment;
 
 /**
  *
@@ -351,6 +352,7 @@ private void runRenamedTest(String fname, String cset, String content) throws Ex
 
     @Test
     public void testRenamedHistory() throws Exception {
+        RuntimeEnvironment.getInstance().setHandleHistoryOfRenamedFiles(true);
         File root = new File(repository.getSourceRoot(), "git");
         GitRepository gitrepo
                 = (GitRepository) RepositoryFactory.getRepository(root);
@@ -381,6 +383,7 @@ public void testRenamedHistory() throws Exception {
 
     @Test
     public void testRenamedSingleHistory() throws Exception {
+        RuntimeEnvironment.getInstance().setHandleHistoryOfRenamedFiles(true);
         File root = new File(repository.getSourceRoot(), "git");
         GitRepository gitrepo
                 = (GitRepository) RepositoryFactory.getRepository(root);