Share TAGS_SEPARATOR named literal

Author: idodeclare

opengrok-indexer/src/main/java/org/opengrok/indexer/history/BazaarTagParser.java

@@ -19,9 +19,12 @@
 
 /*
  * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
+ * Portions Copyright (c) 2019, Chris Fraire <[email protected]>.
  */
 package org.opengrok.indexer.history;
 
+import static org.opengrok.indexer.history.HistoryEntry.TAGS_SEPARATOR;
+
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStream;
@@ -70,7 +73,7 @@ public void processStream(InputStream input) throws IOException {
                 if (higher != null && higher.equals(tagEntry)) {
                     // Found in the tree, merge tags
                     entries.remove(higher);
-                    tagEntry.setTags(higher.getTags() + ", " + tag);
+                    tagEntry.setTags(higher.getTags() + TAGS_SEPARATOR + tag);
                 }
                 entries.add(tagEntry);
             }

opengrok-indexer/src/main/java/org/opengrok/indexer/history/GitTagParser.java

@@ -19,10 +19,12 @@
 
 /*
  * Copyright (c) 2018, 2019 Oracle and/or its affiliates. All rights reserved.
- * Portions Copyright (c) 2020, Chris Fraire <[email protected]>.
+ * Portions Copyright (c) 2019-2020, Chris Fraire <[email protected]>.
  */
 package org.opengrok.indexer.history;
 
+import static org.opengrok.indexer.history.HistoryEntry.TAGS_SEPARATOR;
+
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStream;
@@ -114,7 +116,7 @@ public void processStream(InputStream input) throws IOException {
                      * See Repository assignTagsInHistory() where multiple
                      * identified tags are joined with comma-space.
                      */
-                    String joinedTagNames = String.join(", ", tagNames);
+                    String joinedTagNames = String.join(TAGS_SEPARATOR, tagNames);
                     GitTagEntry tagEntry = new GitTagEntry(hash, date, joinedTagNames);
                     entries.add(tagEntry);
                 }

opengrok-indexer/src/main/java/org/opengrok/indexer/history/HistoryEntry.java

@@ -19,6 +19,7 @@
 
 /*
  * Copyright (c) 2006, 2018 Oracle and/or its affiliates. All rights reserved.
+ * Portions Copyright (c) 2019, Chris Fraire <[email protected]>.
  */
 /*
  * Copyright 2006 Trond Norbye.  All rights reserved.
@@ -30,6 +31,7 @@
 import java.util.TreeSet;
 import java.util.logging.Level;
 import java.util.logging.Logger;
+
 import org.opengrok.indexer.logger.LoggerFactory;
 
 /**
@@ -39,6 +41,8 @@
  */
 public class HistoryEntry {
 
+    static final String TAGS_SEPARATOR = ", ";
+
     private static final Logger LOGGER = LoggerFactory.getLogger(HistoryEntry.class);
 
     private String revision;