Skip to content

Commit f5ff778

Browse files
ahornaceVladimir Kotal
authored andcommitted
Extract duplicated code for replacing input value with suggestion into separate function
1 parent 05ab4e1 commit f5ff778

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

web/js/utils-0.0.23.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1845,18 +1845,12 @@ function initAutocompleteForField(inputId, field, config, dataFunction, errorEle
18451845
event.preventDefault();
18461846
return;
18471847
}
1848-
var pos = text.indexOf(identifier);
1849-
var phrase = escapeLuceneCharacters(ui.item.phrase);
1850-
input.val(text.replace(identifier, phrase));
1851-
input.caret(pos + phrase.length);
1848+
replaceValueWithSuggestion(input, text, identifier, ui.item.phrase);
18521849

18531850
event.preventDefault(); // to prevent the movement of the caret to the end
18541851
},
18551852
select: function (event, ui) {
1856-
var pos = text.indexOf(identifier);
1857-
var phrase = escapeLuceneCharacters(ui.item.phrase);
1858-
input.val(text.replace(identifier, phrase));
1859-
input.caret(pos + phrase.length);
1853+
replaceValueWithSuggestion(input, text, identifier, ui.item.phrase);
18601854

18611855
event.preventDefault(); // to prevent the movement of the caret to the end
18621856
},
@@ -1903,6 +1897,13 @@ function getAutocompleteMenuData(input, field) {
19031897
}
19041898
}
19051899

1900+
function replaceValueWithSuggestion(input, queryText, identifier, suggestion) {
1901+
var pos = queryText.indexOf(identifier);
1902+
var phrase = escapeLuceneCharacters(suggestion);
1903+
input.val(queryText.replace(identifier, phrase));
1904+
input.caret(pos + phrase.length);
1905+
}
1906+
19061907
function showError(errorText, errorElem) {
19071908
var parent = errorElem.parent();
19081909

0 commit comments

Comments
 (0)