Skip to content

Commit fc55df9

Browse files
tulinkryVladimir Kotal
authored andcommitted
improve logging of 403 HTTP errors (#1613)
fixes #1611
1 parent 6d9f23a commit fc55df9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/org/opensolaris/opengrok/web/AuthorizationFilter.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,23 @@ public void doFilter(ServletRequest sr, ServletResponse sr1, FilterChain fc) thr
5454

5555
Project p = config.getProject();
5656
if (p != null && !config.isAllowed(p)) {
57-
LOGGER.log(Level.INFO, "access denied for uri: {0}", httpReq.getRequestURI());
57+
if (httpReq.getRemoteUser() != null) {
58+
LOGGER.log(Level.INFO, "Access denied for user ''{0}'' for URI: {1}",
59+
new Object[]{httpReq.getRemoteUser(),
60+
httpReq.getRequestURI()});
61+
} else {
62+
LOGGER.log(Level.INFO, "Access denied for URI: {0}", httpReq.getRequestURI());
63+
}
5864
config.getEnv().getStatistics().addRequest(httpReq);
5965
config.getEnv().getStatistics().addRequest(httpReq, "requests_forbidden");
6066
config.getEnv().getStatistics().addRequestTime(httpReq,
6167
"requests_forbidden",
6268
System.currentTimeMillis() - processTime);
63-
6469
if (!config.getEnv().getConfiguration().getForbiddenIncludeFileContent().isEmpty()) {
6570
sr.getRequestDispatcher("/eforbidden").forward(sr, sr1);
6671
return;
6772
}
68-
httpRes.sendError(403, "Access forbidden");
73+
httpRes.sendError(HttpServletResponse.SC_FORBIDDEN, "Access forbidden");
6974
return;
7075
}
7176
fc.doFilter(sr, sr1);

0 commit comments

Comments
 (0)