From deda3656084c5b8cdaf2e5880f416fee66e5a297 Mon Sep 17 00:00:00 2001 From: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com> Date: Fri, 31 Jan 2025 00:31:30 -0300 Subject: [PATCH] Update WildCardMatcherTest.java Improves the readability of the test. Splitting assertions into separate tests improves clarity and ensures each test verifies a single scenario or state. This enhances readability, maintainability, and debugging efficiency. --- .../indexer/search/context/WildCardMatcherTest.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/opengrok-indexer/src/test/java/org/opengrok/indexer/search/context/WildCardMatcherTest.java b/opengrok-indexer/src/test/java/org/opengrok/indexer/search/context/WildCardMatcherTest.java index 07e7e475b3e..83475e71b48 100644 --- a/opengrok-indexer/src/test/java/org/opengrok/indexer/search/context/WildCardMatcherTest.java +++ b/opengrok-indexer/src/test/java/org/opengrok/indexer/search/context/WildCardMatcherTest.java @@ -35,26 +35,32 @@ class WildCardMatcherTest { * Test of match method. */ @Test - void testMatch() { + void testMatchWildPatternQuestionMark() { WildCardMatcher m = new WildCardMatcher("wild?ard", true); // bug #15644 + assertEquals(LineMatcher.MATCHED, m.match("wildcard")); assertEquals(LineMatcher.MATCHED, m.match("wildward")); assertEquals(LineMatcher.MATCHED, m.match("wilddard")); assertEquals(LineMatcher.MATCHED, m.match("wild?ard")); + assertEquals(LineMatcher.NOT_MATCHED, m.match("wildard")); assertEquals(LineMatcher.NOT_MATCHED, m.match("wildcarde")); assertEquals(LineMatcher.NOT_MATCHED, m.match("awildcard")); assertEquals(LineMatcher.NOT_MATCHED, m.match("wildddard")); assertEquals(LineMatcher.NOT_MATCHED, m.match("mildcard")); assertEquals(LineMatcher.NOT_MATCHED, m.match("wildc?rd")); + } + + @Test + void testMatchWildPatternAsterisk() { + WildCardMatcher m = new WildCardMatcher("wild*ard", true); - m = new WildCardMatcher("wild*ard", true); assertEquals(LineMatcher.MATCHED, m.match("wildcard")); assertEquals(LineMatcher.MATCHED, m.match("wildward")); assertEquals(LineMatcher.MATCHED, m.match("wilddard")); assertEquals(LineMatcher.MATCHED, m.match("wildard")); assertEquals(LineMatcher.MATCHED, m.match("wildxyzard")); - assertEquals(LineMatcher.MATCHED, m.match("wildxyzard")); + assertEquals(LineMatcher.NOT_MATCHED, m.match("wild")); assertEquals(LineMatcher.NOT_MATCHED, m.match("ard")); assertEquals(LineMatcher.NOT_MATCHED, m.match("wildcat"));