From d5062ef772a8c9fd807e9c739681a1cabdf0f143 Mon Sep 17 00:00:00 2001 From: Vladimir Kotal Date: Tue, 2 Sep 2025 08:53:49 +0200 Subject: [PATCH 1/3] remove redundant public modifier --- opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java b/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java index 04760f8c0af..2758e41eeff 100644 --- a/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java +++ b/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java @@ -80,7 +80,7 @@ class PageConfigTest { private static TestRepository repository = new TestRepository(); @BeforeAll - public static void setUpClass() throws Exception { + static void setUpClass() throws Exception { RuntimeEnvironment env = RuntimeEnvironment.getInstance(); env.setHistoryEnabled(true); From 3e992c15b350468c6ca9c7348f15ab9fff36a05d Mon Sep 17 00:00:00 2001 From: Vladimir Kotal Date: Tue, 2 Sep 2025 08:54:00 +0200 Subject: [PATCH 2/3] check results of mkdirs()/delete() --- .../src/test/java/org/opengrok/web/PageConfigTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java b/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java index 2758e41eeff..a8e70108f6d 100644 --- a/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java +++ b/opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java @@ -598,8 +598,8 @@ void testCheckSourceRootExistence5() throws IOException { PageConfig cfg = PageConfig.get(req); String path = RuntimeEnvironment.getInstance().getSourceRootPath(); File temp = File.createTempFile("opengrok", "-test-file.tmp"); - temp.delete(); - temp.mkdirs(); + assertTrue(temp.delete()); + assertTrue(temp.mkdirs()); RuntimeEnvironment.getInstance().setSourceRoot(temp.getAbsolutePath()); cfg.checkSourceRootExistence(); RuntimeEnvironment.getInstance().setSourceRoot(path); From 97bec413ca5d161bbbae0c0b9b29c34ecf5b5cc8 Mon Sep 17 00:00:00 2001 From: Vladimir Kotal Date: Tue, 2 Sep 2025 08:55:15 +0200 Subject: [PATCH 3/3] remove redundant image word screen readers announce the img element and that is enough --- opengrok-web/src/main/webapp/diff.jsp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opengrok-web/src/main/webapp/diff.jsp b/opengrok-web/src/main/webapp/diff.jsp index a2d9cc45c79..07ef467c233 100644 --- a/opengrok-web/src/main/webapp/diff.jsp +++ b/opengrok-web/src/main/webapp/diff.jsp @@ -112,9 +112,9 @@ include file="/mast.jsp" - previous image + previous - new image + new