Fix missing error-checks enforced by Hashicorp

Author: alexng-canuck

provider/core_local_peering_gateway_resource.go

@@ -212,7 +212,10 @@ func (s *LocalPeeringGatewayResourceCrud) ConnectLocalPeeringGateway() error {
 			s.D.Set("peer_id", "")
 			return fmt.Errorf("unexpected Peering Status `%s` after trying to connect to the peer Local Peering Gateway", string(response.LocalPeeringGateway.PeeringStatus))
 		}
-		s.SetData()
+
+		if err := s.SetData(); err != nil {
+			return err
+		}
 	}
 	return nil
 }

provider/core_remote_peering_connection_resource.go

@@ -213,7 +213,10 @@ func (s *RemotePeeringConnectionResourceCrud) ConnectRemotePeeringConnection() e
 		s.D.Set("peer_id", "")
 		return fmt.Errorf("unexpected Peering Status `%s` after trying to connect to the peer Remote Peering Connection (RPC). Make sure the peering_status of the peer RPC is not REVOKED", string(response.RemotePeeringConnection.PeeringStatus))
 	}
-	s.SetData()
+
+	if err := s.SetData(); err != nil {
+		return err
+	}
 
 	return nil
 }

provider/identity_compartment_resource.go

@@ -209,8 +209,7 @@ func (s *CompartmentResourceCrud) Create() error {
 				s.Res = &compartment
 				//Update with correct description
 				s.D.SetId(s.ID())
-				s.Update()
-				return nil
+				return s.Update()
 			}
 		}
 	}

provider/test_helpers.go

@@ -5,6 +5,7 @@ package provider
 import (
 	"bytes"
 	"fmt"
+	"log"
 	"text/template"
 	"time"
 
@@ -18,7 +19,9 @@ var tmpl template.Template = *template.New("tmpl")
 func apply(template string, values map[string]string) string {
 	b := new(bytes.Buffer)
 	t, _ := tmpl.Parse(template)
-	t.Execute(b, values)
+	if err := t.Execute(b, values); err != nil {
+		log.Printf("[WARN] Unable to apply values to template: '%s'", err)
+	}
 	return b.String()
 }