Skip to content

Commit 0298baa

Browse files
author
jiangong
committed
fix TestApplyFiltersIntegration_basic test failure
1 parent a3b260d commit 0298baa

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

oci/core_instance_resource.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ func InstanceResource() *schema.Resource {
205205
Computed: true,
206206
ForceNew: true,
207207
MaxItems: 1,
208-
MinItems: 0,
208+
MinItems: 1,
209209
Elem: &schema.Resource{
210210
Schema: map[string]*schema.Schema{
211211
// Required

oci/filters_integration_test.go

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,6 @@ func TestApplyFiltersIntegration_basic(t *testing.T) {
5959
// verify datasource id
6060
{
6161
Config: config + `
62-
variable "InstanceImageOCID" {
63-
type = "map"
64-
default = {
65-
// See https://docs.us-phoenix-1.oraclecloud.com/images/
66-
// Oracle-provided image "Oracle-Linux-7.5-2018.10.16-0"
67-
us-phoenix-1 = "ocid1.image.oc1.phx.aaaaaaaaoqj42sokaoh42l76wsyhn3k2beuntrh5maj3gmgmzeyr55zzrwwa"
68-
us-ashburn-1 = "ocid1.image.oc1.iad.aaaaaaaageeenzyuxgia726xur4ztaoxbxyjlxogdhreu3ngfj2gji3bayda"
69-
eu-frankfurt-1 = "ocid1.image.oc1.eu-frankfurt-1.aaaaaaaaitzn6tdyjer7jl34h2ujz74jwy5nkbukbh55ekp6oyzwrtfa4zma"
70-
uk-london-1 = "ocid1.image.oc1.uk-london-1.aaaaaaaa32voyikkkzfxyo4xbdmadc2dmvorfxxgdhpnk6dw64fa3l4jh7wa"
71-
}
72-
}
7362
variable "instance_create_vnic_details_defined_tags_value" { default = "definedTags" }
7463
variable "instance_create_vnic_details_display_name" { default = "displayName" }
7564
variable "instance_create_vnic_details_freeform_tags" { default = {"Department"= "Accounting"} }
@@ -153,7 +142,7 @@ data "oci_core_instances" "test_instances_filter_out_with_map" {
153142
values = ["${oci_core_instance.test_instance.id}"]
154143
}
155144
156-
filter {
145+
filter {
157146
name = "defined_tags.${oci_identity_tag_namespace.tag-namespace1.name}.${oci_identity_tag.tag1.name}"
158147
values = ["${var.instance_defined_tags_value}.blah"]
159148
}

0 commit comments

Comments
 (0)