Add new datasource instance test (#286)

Author: scotmoor

data_source_obmcs_core_instance.go

@@ -25,6 +25,10 @@ func InstanceDatasource() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 			},
+			"display_name": {
+				Type:     schema.TypeString,
+				Optional: true,
+			},
 			"page": {
 				Type:     schema.TypeString,
 				Optional: true,
@@ -118,8 +122,11 @@ func (s *InstanceDatasourceCrud) Get() (e error) {
 
 	opts := &baremetal.ListInstancesOptions{}
 	options.SetListOptions(s.D, &opts.ListOptions)
-	if val, ok := s.D.GetOk("availability_domain"); ok {
-		opts.AvailabilityDomain = val.(string)
+	if ad, ok := s.D.GetOk("availability_domain"); ok {
+		opts.AvailabilityDomain = ad.(string)
+	}
+	if dispName, ok := s.D.GetOk("display_name"); ok {
+		opts.DisplayName = dispName.(string)
 	}
 
 	s.Res = &baremetal.ListInstances{Instances: []baremetal.Instance{}}

data_source_obmcs_core_instance_test.go

@@ -0,0 +1,116 @@
+// Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+
+package main
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform/helper/resource"
+	"github.com/hashicorp/terraform/terraform"
+	baremetal "github.com/oracle/bmcs-go-sdk"
+
+	"github.com/stretchr/testify/suite"
+)
+
+type DatasourceCoreInstanceTestSuite struct {
+	suite.Suite
+	Client       *baremetal.Client
+	Config       string
+	Provider     terraform.ResourceProvider
+	Providers    map[string]terraform.ResourceProvider
+	ResourceName string
+	Token        string
+	TokenFn      func(string, map[string]string) string
+}
+
+func (s *DatasourceCoreInstanceTestSuite) SetupTest() {
+	s.Token, s.TokenFn = tokenize()
+	s.Client = testAccClient
+	s.Provider = testAccProvider
+	s.Providers = testAccProviders
+	s.Config = testProviderConfig() + s.TokenFn(`
+	data "oci_identity_availability_domains" "ADs" {
+		compartment_id = "${var.compartment_id}"
+	}
+
+	resource "oci_core_virtual_network" "t" {
+		compartment_id = "${var.compartment_id}"
+		display_name = "-tf-vcn"
+		cidr_block = "10.0.0.0/16"
+	}
+
+	resource "oci_core_subnet" "t" {
+		availability_domain = "${lookup(data.oci_identity_availability_domains.ADs.availability_domains[0],"name")}"
+		compartment_id      = "${var.compartment_id}"
+		vcn_id              = "${oci_core_virtual_network.t.id}"
+		display_name        = "-tf-subnet"
+		cidr_block          = "10.0.1.0/24"
+		dhcp_options_id     = "${oci_core_virtual_network.t.default_dhcp_options_id}"
+		route_table_id      = "${oci_core_virtual_network.t.default_route_table_id}"
+		security_list_ids = ["${oci_core_virtual_network.t.default_security_list_id}"]
+	}
+
+	data "oci_core_images" "t" {
+		compartment_id = "${var.compartment_id}"
+		operating_system = "Oracle Linux"
+		operating_system_version = "7.3"
+		limit = 1
+	}
+
+	resource "oci_core_instance" "t" {
+		availability_domain = "${data.oci_identity_availability_domains.ADs.availability_domains.0.name}"
+		compartment_id = "${var.compartment_id}"
+		display_name = "{{.token}}"
+		subnet_id = "${oci_core_subnet.t.id}"
+		image = "${data.oci_core_images.t.images.0.id}"
+		shape = "VM.Standard1.1"
+		metadata {
+			ssh_authorized_keys = "${var.ssh_public_key}"
+		}
+		timeouts {
+			create = "15m"
+		}
+	}`, nil)
+
+	s.ResourceName = "data.oci_core_instances.t"
+}
+
+func (s *DatasourceCoreInstanceTestSuite) TestAccDatasourceCoreInstance_basic() {
+
+	resource.Test(s.T(), resource.TestCase{
+		PreventPostDestroyRefresh: true,
+		Providers:                 s.Providers,
+		Steps: []resource.TestStep{
+			{
+				ImportState:       true,
+				ImportStateVerify: true,
+				Config:            s.Config,
+			},
+			{
+				Config: s.Config + s.TokenFn(`
+				data "oci_core_instances" "t" {
+					compartment_id = "${var.compartment_id}"
+					availability_domain = "${data.oci_identity_availability_domains.ADs.availability_domains.0.name}"
+					display_name = "{{.token}}"
+					limit = 1
+				}`, nil),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(s.ResourceName, "instances.#", "1"),
+					resource.TestCheckResourceAttr(s.ResourceName, "instances.0.display_name", s.Token),
+					resource.TestCheckResourceAttr(s.ResourceName, "instances.0.state", "RUNNING"),
+					resource.TestCheckResourceAttr(s.ResourceName, "instances.0.shape", "VM.Standard1.1"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "instances.0.availability_domain"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "instances.0.id"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "instances.0.region"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "instances.0.image"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "instances.0.metadata.%"),
+				),
+			},
+		},
+	},
+	)
+}
+
+func TestDatasourceCoreInstanceTestSuite(t *testing.T) {
+	suite.Run(t, new(DatasourceCoreInstanceTestSuite))
+}