Skip to content

Commit 1424262

Browse files
vcn_id now saved in tfstate file correctly. This enables the terraform import scenarios
1 parent 024d14b commit 1424262

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

provider/core_dhcp_options_data_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func (s *DHCPOptionsDatasourceCrud) SetData() {
109109
"options": nestedStateObjs,
110110
"state": res.State,
111111
"time_created": res.TimeCreated.String(),
112-
"vcn_id": s.D.Get("vcn_id").(string), // todo: get this off the resource result
112+
"vcn_id": res.VcnID,
113113
}
114114
resources = append(resources, stateObj)
115115
}

provider/core_route_table_resource_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ func (s *ResourceCoreRouteTableTestSuite) TestAccResourceCoreRouteTable_basic()
7272
}`,
7373
Check: resource.ComposeTestCheckFunc(
7474
resource.TestCheckResourceAttrSet(s.ResourceName, "display_name"),
75-
resource.TestCheckResourceAttrSet(s.ResourceName, "vcn_in"),
75+
resource.TestCheckResourceAttrSet(s.ResourceName, "vcn_id"),
76+
resource.TestCheckResourceAttrSet(s.ResourceName, "compartment_id"),
7677
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.#", "0"),
7778
resource.TestCheckResourceAttrSet(s.DefaultResourceName, "display_name"),
7879
resource.TestCheckResourceAttr(s.DefaultResourceName, "route_rules.#", "0"),
79-
resource.TestCheckResourceAttrSet(s.DefaultResourceName, "vcn_in"),
8080
),
8181
},
8282
// verify add rule
@@ -92,6 +92,8 @@ func (s *ResourceCoreRouteTableTestSuite) TestAccResourceCoreRouteTable_basic()
9292
}` + defaultRouteTable,
9393
Check: resource.ComposeTestCheckFunc(
9494
resource.TestCheckResourceAttrSet(s.ResourceName, "display_name"),
95+
resource.TestCheckResourceAttrSet(s.ResourceName, "vcn_id"),
96+
resource.TestCheckResourceAttrSet(s.ResourceName, "compartment_id"),
9597
resource.TestCheckResourceAttrSet(s.ResourceName, "route_rules.0.network_entity_id"),
9698
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.#", "1"),
9799
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.0.cidr_block", "0.0.0.0/0"),
@@ -131,6 +133,8 @@ func (s *ResourceCoreRouteTableTestSuite) TestAccResourceCoreRouteTable_basic()
131133
}`,
132134
Check: resource.ComposeTestCheckFunc(
133135
resource.TestCheckResourceAttr(s.ResourceName, "display_name", "-tf-route-table"),
136+
resource.TestCheckResourceAttrSet(s.ResourceName, "vcn_id"),
137+
resource.TestCheckResourceAttrSet(s.ResourceName, "compartment_id"),
134138
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.#", "2"),
135139
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.0.cidr_block", "0.0.0.0/0"),
136140
resource.TestCheckResourceAttr(s.ResourceName, "route_rules.1.cidr_block", "10.0.0.0/8"),
@@ -150,7 +154,6 @@ func (s *ResourceCoreRouteTableTestSuite) TestAccResourceCoreRouteTable_basic()
150154
Config: s.Config + defaultRouteTable,
151155
Check: resource.ComposeTestCheckFunc(
152156
resource.TestCheckResourceAttrSet(s.DefaultResourceName, "display_name"),
153-
resource.TestCheckResourceAttrSet(s.DefaultResourceName, "vcn_in"),
154157
resource.TestCheckResourceAttrSet(s.DefaultResourceName, "route_rules.0.network_entity_id"),
155158
resource.TestCheckResourceAttr(s.DefaultResourceName, "route_rules.#", "1"),
156159
resource.TestCheckResourceAttr(s.DefaultResourceName, "route_rules.0.cidr_block", "0.0.0.0/0"),

provider/core_route_tables_data_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func (s *RouteTableDatasourceCrud) SetData() {
108108
"state": v.State,
109109
"time_created": v.TimeCreated.String(),
110110
"time_modified": v.TimeModified.String(),
111-
"vcn_id": s.D.Get("vcn_id").(string), // todo: get this off the route table result
111+
"vcn_id": v.VcnID,
112112
}
113113
resources = append(resources, res)
114114
}

0 commit comments

Comments
 (0)