Update vendor folder with latest govendor sync

This involves reenabling schema checks that were previously
disabled.

We also update our schemas to ensure the schema checks are passing.

Author: alexng-canuck

provider/core_boot_volumes_data_source.go

@@ -46,10 +46,9 @@ func BootVolumesDataSource() *schema.Resource {
 							Computed: true,
 						},
 						"defined_tags": {
-							Type:             schema.TypeMap,
-							Computed:         true,
-							DiffSuppressFunc: definedTagsDiffSuppressFunction,
-							Elem:             schema.TypeString,
+							Type:     schema.TypeMap,
+							Computed: true,
+							Elem:     schema.TypeString,
 						},
 						"display_name": {
 							Type:     schema.TypeString,

provider/core_public_ip_data_source.go

@@ -43,10 +43,9 @@ func PublicIpDataSource() *schema.Resource {
 				Computed: true,
 			},
 			"defined_tags": {
-				Type:             schema.TypeMap,
-				Computed:         true,
-				DiffSuppressFunc: definedTagsDiffSuppressFunction,
-				Elem:             schema.TypeString,
+				Type:     schema.TypeMap,
+				Computed: true,
+				Elem:     schema.TypeString,
 			},
 			"display_name": {
 				Type:     schema.TypeString,

provider/core_vnic_data_source.go

@@ -27,10 +27,9 @@ func VnicDataSource() *schema.Resource {
 				Computed: true,
 			},
 			"defined_tags": {
-				Type:             schema.TypeMap,
-				Computed:         true,
-				DiffSuppressFunc: definedTagsDiffSuppressFunction,
-				Elem:             schema.TypeString,
+				Type:     schema.TypeMap,
+				Computed: true,
+				Elem:     schema.TypeString,
 			},
 			"display_name": {
 				Type:     schema.TypeString,

provider/crud_helpers.go

@@ -502,5 +502,31 @@ func GetDataSourceItemSchema(resourceSchema *schema.Resource) *schema.Resource {
 		}
 	}
 
+	// Ensure Create/Read are not set for nested sub-resource schemas. Otherwise, terraform will validate them
+	// as though they were resources.
+	resourceSchema.Create = nil
+	resourceSchema.Read = nil
+
+	return convertResourceFieldsToDatasourceFields(resourceSchema)
+}
+
+// This is mainly used to ensure that fields of a datasource item are compliant with Terraform schema validation
+// All datasource return items should have computed-only fields; and not require Diff, Validation, or Default settings.
+func convertResourceFieldsToDatasourceFields(resourceSchema *schema.Resource) *schema.Resource {
+	for _, fieldSchema := range resourceSchema.Schema {
+		fieldSchema.Computed = true
+		fieldSchema.Required = false
+		fieldSchema.Optional = false
+		fieldSchema.DiffSuppressFunc = nil
+		fieldSchema.ValidateFunc = nil
+		fieldSchema.Default = nil
+
+		if fieldSchema.Elem != nil {
+			if resource, ok := fieldSchema.Elem.(*schema.Resource); ok {
+				fieldSchema.Elem = convertResourceFieldsToDatasourceFields(resource)
+			}
+		}
+	}
+
 	return resourceSchema
 }

provider/database_database_data_source.go

@@ -62,10 +62,9 @@ func DatabaseDataSource() *schema.Resource {
 				Computed: true,
 			},
 			"defined_tags": {
-				Type:             schema.TypeMap,
-				Computed:         true,
-				DiffSuppressFunc: definedTagsDiffSuppressFunction,
-				Elem:             schema.TypeString,
+				Type:     schema.TypeMap,
+				Computed: true,
+				Elem:     schema.TypeString,
 			},
 			"freeform_tags": {
 				Type:     schema.TypeMap,

provider/identity_tenancy_data_source.go

@@ -19,10 +19,9 @@ func TenancyDataSource() *schema.Resource {
 			},
 			// Computed
 			"defined_tags": {
-				Type:             schema.TypeMap,
-				Computed:         true,
-				DiffSuppressFunc: definedTagsDiffSuppressFunction,
-				Elem:             schema.TypeString,
+				Type:     schema.TypeMap,
+				Computed: true,
+				Elem:     schema.TypeString,
 			},
 			"description": {
 				Type:     schema.TypeString,