Add subcategories to docs for Terraform Registry

* Add subcategories to docs for Terraform Registry

We will soon be displaying documentation for this provider both on
[terraform.io](https://www.terraform.io/docs/providers/index.html)
and on [the Terraform Registry](https://registry.terraform.io/providers).

Documentation displayed on the Terraform Registry will not use the ERB
layout containing the existing navigation, and will instead build the
navigation dynamically based on the directory and YAML frontmatter of a file.
For providers that group similar resources and data sources by service or
use case (subcategories), we'll need to add this information to the
Markdown source file.

This PR modifies Resource and Data Source documentation source files by
adding a subcategory to the metadata if those files were grouped previously.

For more information about how documentation is rendered on the
Terraform Registry, please see this reference:
[Terraform Registry - Provider Documentation](https://www.terraform.io/docs/registry/providers/docs.html).

* Add Docs Check Script

Add script to check docs compatibility with Terraform Registry
importing.

* Manually Add Subcategory for Core Shape Management

The docscheck script discovered that the oci_core_shape_management
documentation was missing subcategory data. Manually adding the
meta data to the document.

* Update doscheck script for data sources

* Add test-docscheck make target to verify.bash

Author: pwelch

GNUmakefile

@@ -90,6 +90,9 @@ ifeq (,$(wildcard $(GOPATH)/src/$(WEBSITE_REPO)))
 endif
 	@$(MAKE) -C $(GOPATH)/src/$(WEBSITE_REPO) website-provider-test PROVIDER_PATH=$(shell pwd) PROVIDER_NAME=$(PKG_NAME)
 
+test-docscheck:
+	@sh -c "'$(CURDIR)/scripts/docscheck.sh'"
+
 ## Additional OCI stuff that will need to be moved eventually
 get: ;go get golang.org/x/tools/cmd/goimports; go get github.com/mitchellh/gox
 
@@ -129,4 +132,4 @@ zip:
 	tar -czvf openbsd_amd64.tar.gz openbsd_amd64; \
 	tar -czvf solaris_amd64.tar.gz solaris_amd64
 
-.PHONY: build test testacc vet fmt fmtcheck errcheck test-compile website website-test
+.PHONY: build test testacc vet fmt fmtcheck errcheck test-compile website website-test test-docscheck

scripts/docscheck.sh

@@ -0,0 +1,40 @@
+#!/usr/bin/env bash
+
+docs=$(ls website/docs/**/*.markdown)
+error=false
+
+for doc in $docs; do
+  dirname=$(dirname "$doc")
+  category=$(basename "$dirname")
+
+
+  case "$category" in
+    "guides")
+      # Guides require a page_title
+      if ! grep "^page_title: " "$doc" > /dev/null; then
+        echo "Guide is missing a page_title: $doc"
+        error=true
+      fi
+      ;;
+
+    "d" | "r")
+      # Resources and data sources require a subcategory
+      if ! grep "^subcategory: " "$doc" > /dev/null; then
+        echo "Doc is missing a subcategory: $doc"
+        error=true
+      fi
+      ;;
+
+    *)
+      error=true
+      echo "Unknown category \"$category\". " \
+        "Docs can only exist in r/, d/, or guides/ folders."
+      ;;
+  esac
+done
+
+if $error; then
+  exit 1
+fi
+
+exit 0

scripts/verify.bash

@@ -35,6 +35,7 @@ check_make_target 3 'errcheck'
 check_make_target 5 'test-compile' 'TEST=./oci'
 check_make_target 6 'ocicheck'
 check_make_target 7 'website-test'
+check_make_target 8 'test-docscheck'
 
 
 echo "checking: make build ..."