add Support resource discovery for oda resources

Author: zexinwanoci

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Support for Tags in Shared DB Home resource
 - Support `oci_database_autonomous_vm_cluster` for service `database`
 - Support for `mount_type_details`, `mount_type`, `nfs_server` and `nfs_server_export` attributes in `oci_database_backup_destination` resource
+- Support resource discovery for `ons` resources
 
 ### Notes
 - `mount_type_details` attribute needs to be set when `type` attribute is set to `NFS` in `oci_database_backup_destination` resource

oci/export_definitions.go

@@ -28,6 +28,7 @@ import (
 	oci_nosql "github.com/oracle/oci-go-sdk/nosql"
 	oci_oce "github.com/oracle/oci-go-sdk/oce"
 	oci_oda "github.com/oracle/oci-go-sdk/oda"
+	oci_ons "github.com/oracle/oci-go-sdk/ons"
 	oci_osmanagement "github.com/oracle/oci-go-sdk/osmanagement"
 	oci_streaming "github.com/oracle/oci-go-sdk/streaming"
 	oci_waas "github.com/oracle/oci-go-sdk/waas"
@@ -1262,6 +1263,16 @@ var exportObjectStoragePreauthenticatedRequestHints = &TerraformResourceHints{
 	resourceAbbreviation: "preauthenticated_request",
 }
 
+var exportOnsNotificationTopicHints = &TerraformResourceHints{
+	resourceClass:        "oci_ons_notification_topic",
+	datasourceClass:      "oci_ons_notification_topics",
+	datasourceItemsAttr:  "notification_topics",
+	resourceAbbreviation: "notification_topic",
+	discoverableLifecycleStates: []string{
+		string(oci_ons.NotificationTopicLifecycleStateActive),
+	},
+}
+
 var exportOsmanagementManagedInstanceGroupHints = &TerraformResourceHints{
 	resourceClass:        "oci_osmanagement_managed_instance_group",
 	datasourceClass:      "oci_osmanagement_managed_instance_groups",

oci/export_graphs.go

@@ -72,6 +72,7 @@ var compartmentResourceGraphs = map[string]TerraformResourceGraph{
 	"object_storage":      objectStorageResourceGraph,
 	"oce":                 oceResourceGraph,
 	"oda":                 odaResourceGraph,
+	"ons":                 onsResourceGraph,
 	"osmanagement":        osmanagementResourceGraph,
 	"streaming":           streamingResourceGraph,
 	"tagging":             taggingResourceGraph,
@@ -648,6 +649,12 @@ var odaResourceGraph = TerraformResourceGraph{
 	},
 }
 
+var onsResourceGraph = TerraformResourceGraph{
+	"oci_identity_compartment": {
+		{TerraformResourceHints: exportOnsNotificationTopicHints},
+	},
+}
+
 var osmanagementResourceGraph = TerraformResourceGraph{
 	"oci_identity_compartment": {
 		{TerraformResourceHints: exportOsmanagementManagedInstanceGroupHints},

oci/export_resource_helpers.go

@@ -338,6 +338,8 @@ func init() {
 	exportObjectStorageNamespaceHints.getHCLStringOverrideFn = getObjectStorageNamespaceHCLDatasource
 	exportObjectStorageNamespaceHints.alwaysExportable = true
 
+	exportOnsNotificationTopicHints.getIdFn = getOnsNotificationTopicId
+
 	exportObjectStorageBucketHints.getIdFn = getObjectStorageBucketId
 	exportObjectStorageObjectHints.getIdFn = getObjectStorageObjectId
 	exportObjectStorageObjectHints.requireResourceRefresh = true
@@ -823,6 +825,14 @@ func processLoadBalancerCertificates(clients *OracleClients, resources []*OCIRes
 	return resources, nil
 }
 
+func getOnsNotificationTopicId(resource *OCIResource) (string, error) {
+	id, ok := resource.sourceAttributes["topic_id"].(string)
+	if !ok {
+		return "", fmt.Errorf("[ERROR] unable to find topic id for ons notification topic")
+	}
+	return id, nil
+}
+
 func getObjectStorageBucketId(resource *OCIResource) (string, error) {
 	name, ok := resource.sourceAttributes["name"].(string)
 	if !ok {

website/docs/guides/resource_discovery.html.markdown

@@ -119,6 +119,7 @@ The generated `.tf` files contain the Terraform configuration with the resources
     * `oce` - Discovers oce resources within the specified compartment
     * `object_storage` - Discovers object storage resources within the specified compartment
     * `oda` - Discovers oda resources within the specified compartment
+    * `ons` - Discovers ons resources within the specified compartment
     * `osmanagement` - Discovers osmanagement resources within the specified compartment
     * `streaming` - Discovers streaming resources within the specified compartment
     * `tagging` - Discovers tag-related resources within the specified compartment
@@ -419,6 +420,10 @@ oda
 
 * oci\_oda\_oda\_instance
 
+ons
+    
+* oci\_ons\_notification\_topic
+
 osmanagement
 
 * oci\_osmanagement\_managed\_instance\_group