Add support for Enabling Event Notifications on bucket resource

Author: abhilash-av

CHANGELOG.md

@@ -1,4 +1,9 @@
-## 3.44.1 (Unreleased)
+## 3.45.0 (Unreleased)
+
+### Added
+
+- Support for Event Notifications on `oci_objectstorage_bucket`
+
 ## 3.44.0 (September 18, 2019)
 
 ### Added

oci/objectstorage_bucket_data_source.go

@@ -107,6 +107,10 @@ func (s *ObjectStorageBucketDataSourceCrud) SetData() error {
 
 	s.D.Set("metadata", s.Res.Metadata)
 
+	if s.Res.ObjectEventsEnabled != nil {
+		s.D.Set("object_events_enabled", *s.Res.ObjectEventsEnabled)
+	}
+
 	if s.Res.ObjectLifecyclePolicyEtag != nil {
 		s.D.Set("object_lifecycle_policy_etag", *s.Res.ObjectLifecyclePolicyEtag)
 	}

oci/objectstorage_bucket_resource.go

@@ -72,6 +72,11 @@ func ObjectStorageBucketResource() *schema.Resource {
 				Optional: true,
 				Elem:     schema.TypeString,
 			},
+			"object_events_enabled": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Computed: true,
+			},
 			"storage_tier": {
 				Type:     schema.TypeString,
 				Optional: true,
@@ -196,6 +201,11 @@ func (s *ObjectStorageBucketResourceCrud) Create() error {
 		request.NamespaceName = &tmp
 	}
 
+	if objectEventsEnabled, ok := s.D.GetOkExists("object_events_enabled"); ok {
+		tmp := objectEventsEnabled.(bool)
+		request.ObjectEventsEnabled = &tmp
+	}
+
 	if storageTier, ok := s.D.GetOkExists("storage_tier"); ok {
 		request.StorageTier = oci_object_storage.CreateBucketDetailsStorageTierEnum(storageTier.(string))
 	}
@@ -287,6 +297,11 @@ func (s *ObjectStorageBucketResourceCrud) Update() error {
 		request.NamespaceName = &tmp
 	}
 
+	if objectEventsEnabled, ok := s.D.GetOkExists("object_events_enabled"); ok {
+		tmp := objectEventsEnabled.(bool)
+		request.ObjectEventsEnabled = &tmp
+	}
+
 	// @CODEGEN 2/2018: This should be used to change the name of a bucket, but the "namespace" field
 	// is already being used to identify the bucket. Should have a new field for this.
 	// Existing provider omits this, so we will omit it for now to avoid a potential breaking change.
@@ -379,6 +394,10 @@ func (s *ObjectStorageBucketResourceCrud) SetData() error {
 		s.D.Set("namespace", *s.Res.Namespace)
 	}
 
+	if s.Res.ObjectEventsEnabled != nil {
+		s.D.Set("object_events_enabled", *s.Res.ObjectEventsEnabled)
+	}
+
 	if s.Res.ObjectLifecyclePolicyEtag != nil {
 		s.D.Set("object_lifecycle_policy_etag", *s.Res.ObjectLifecyclePolicyEtag)
 	}

oci/objectstorage_bucket_test.go

@@ -42,15 +42,16 @@ var (
 	}
 
 	bucketRepresentation = map[string]interface{}{
-		"compartment_id": Representation{repType: Required, create: `${var.compartment_id}`},
-		"name":           Representation{repType: Required, create: testBucketName, update: testBucketName2},
-		"namespace":      Representation{repType: Required, create: `${data.oci_objectstorage_namespace.t.namespace}`},
-		"access_type":    Representation{repType: Optional, create: `NoPublicAccess`, update: `ObjectRead`},
-		"defined_tags":   Representation{repType: Optional, create: `${map("${oci_identity_tag_namespace.tag-namespace1.name}.${oci_identity_tag.tag1.name}", "value")}`, update: `${map("${oci_identity_tag_namespace.tag-namespace1.name}.${oci_identity_tag.tag1.name}", "updatedValue")}`},
-		"freeform_tags":  Representation{repType: Optional, create: map[string]string{"Department": "Finance"}, update: map[string]string{"Department": "Accounting"}},
-		"kms_key_id":     Representation{repType: Optional, create: `${lookup(data.oci_kms_keys.test_keys_dependency.keys[0], "id")}`},
-		"metadata":       Representation{repType: Optional, create: map[string]string{"content-type": "text/plain"}, update: map[string]string{"content-type": "text/xml"}},
-		"storage_tier":   Representation{repType: Optional, create: `Standard`},
+		"compartment_id":        Representation{repType: Required, create: `${var.compartment_id}`},
+		"name":                  Representation{repType: Required, create: testBucketName, update: testBucketName2},
+		"namespace":             Representation{repType: Required, create: `${data.oci_objectstorage_namespace.t.namespace}`},
+		"access_type":           Representation{repType: Optional, create: `NoPublicAccess`, update: `ObjectRead`},
+		"defined_tags":          Representation{repType: Optional, create: `${map("${oci_identity_tag_namespace.tag-namespace1.name}.${oci_identity_tag.tag1.name}", "value")}`, update: `${map("${oci_identity_tag_namespace.tag-namespace1.name}.${oci_identity_tag.tag1.name}", "updatedValue")}`},
+		"freeform_tags":         Representation{repType: Optional, create: map[string]string{"Department": "Finance"}, update: map[string]string{"Department": "Accounting"}},
+		"kms_key_id":            Representation{repType: Optional, create: `${lookup(data.oci_kms_keys.test_keys_dependency.keys[0], "id")}`},
+		"metadata":              Representation{repType: Optional, create: map[string]string{"content-type": "text/plain"}, update: map[string]string{"content-type": "text/xml"}},
+		"object_events_enabled": Representation{repType: Optional, create: `false`, update: `true`},
+		"storage_tier":          Representation{repType: Optional, create: `Standard`},
 	}
 
 	BucketResourceDependencies = DefinedTagsDependencies + KeyResourceDependencyConfig + `
@@ -120,6 +121,7 @@ func TestObjectStorageBucketResource_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "metadata.%", "1"),
 					resource.TestCheckResourceAttr(resourceName, "name", testBucketName),
 					resource.TestCheckResourceAttrSet(resourceName, "namespace"),
+					resource.TestCheckResourceAttr(resourceName, "object_events_enabled", "false"),
 					resource.TestCheckResourceAttr(resourceName, "storage_tier", "Standard"),
 					resource.TestCheckResourceAttrSet(resourceName, "time_created"),
 
@@ -185,6 +187,7 @@ func TestObjectStorageBucketResource_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "metadata.%", "1"),
 					resource.TestCheckResourceAttr(resourceName, "name", testBucketName2),
 					resource.TestCheckResourceAttrSet(resourceName, "namespace"),
+					resource.TestCheckResourceAttr(resourceName, "object_events_enabled", "true"),
 					resource.TestCheckResourceAttr(resourceName, "storage_tier", "Standard"),
 					resource.TestCheckResourceAttrSet(resourceName, "time_created"),
 
@@ -242,6 +245,7 @@ func TestObjectStorageBucketResource_basic(t *testing.T) {
 					// This is difficult to test because TF is eager in creating the datasource and gives stale results.
 					// If a depends_on is added, we get an error like "After applying this step and refreshing, the plan was not empty:"
 					//resource.TestCheckResourceAttrSet(singularDatasourceName, "object_lifecycle_policy_etag"),
+					resource.TestCheckResourceAttr(singularDatasourceName, "object_events_enabled", "true"),
 					resource.TestCheckResourceAttr(singularDatasourceName, "storage_tier", "Standard"),
 					resource.TestCheckResourceAttrSet(singularDatasourceName, "time_created"),
 					resource.TestCheckResourceAttrSet(singularDatasourceName, "approximate_count"),

website/docs/d/objectstorage_bucket.html.markdown

@@ -46,6 +46,7 @@ The following attributes are exported:
 * `metadata` - Arbitrary string keys and values for user-defined metadata.
 * `name` - The name of the bucket. Avoid entering confidential information. Example: my-new-bucket1 
 * `namespace` - The Object Storage namespace in which the bucket lives.
+* `object_events_enabled` - A property that determines whether events will be generated for operations on objects in this bucket. This is false by default. 
 * `object_lifecycle_policy_etag` - The entity tag (ETag) for the live object lifecycle policy on the bucket.
 * `storage_tier` - The storage tier type assigned to the bucket. A bucket is set to 'Standard' tier by default, which means objects uploaded or copied to the bucket will be in the standard storage tier. When the 'Archive' tier type is set explicitly for a bucket, objects uploaded or copied to the bucket will be stored in archive storage. The 'storageTier' property is immutable after bucket is created. 
 * `time_created` - The date and time the bucket was created, as described in [RFC 2616](https://tools.ietf.org/rfc/rfc2616), section 14.29.

website/docs/d/objectstorage_bucket_summaries.html.markdown

@@ -57,6 +57,7 @@ The following attributes are exported:
 * `metadata` - Arbitrary string keys and values for user-defined metadata.
 * `name` - The name of the bucket. Avoid entering confidential information. Example: my-new-bucket1 
 * `namespace` - The Object Storage namespace in which the bucket lives.
+* `object_events_enabled` - A property that determines whether events will be generated for operations on objects in this bucket. This is false by default. 
 * `object_lifecycle_policy_etag` - The entity tag (ETag) for the live object lifecycle policy on the bucket.
 * `storage_tier` - The storage tier type assigned to the bucket. A bucket is set to 'Standard' tier by default, which means objects uploaded or copied to the bucket will be in the standard storage tier. When the 'Archive' tier type is set explicitly for a bucket, objects uploaded or copied to the bucket will be stored in archive storage. The 'storageTier' property is immutable after bucket is created. 
 * `time_created` - The date and time the bucket was created, as described in [RFC 2616](https://tools.ietf.org/rfc/rfc2616), section 14.29.

website/docs/r/objectstorage_bucket.html.markdown

@@ -28,6 +28,7 @@ resource "oci_objectstorage_bucket" "test_bucket" {
 	freeform_tags = {"Department"= "Finance"}
 	kms_key_id = "${oci_objectstorage_kms_key.test_kms_key.id}"
 	metadata = "${var.bucket_metadata}"
+	object_events_enabled = "${var.bucket_object_events_enabled}"
 	storage_tier = "${var.bucket_storage_tier}"
 }
 ```
@@ -44,6 +45,7 @@ The following arguments are supported:
 * `metadata` - (Optional) (Updatable) Arbitrary string, up to 4KB, of keys and values for user-defined metadata.
 * `name` - (Required) The name of the bucket. Valid characters are uppercase or lowercase letters, numbers, and dashes. Bucket names must be unique within an Object Storage namespace. Avoid entering confidential information. example: Example: my-new-bucket1 
 * `namespace` - (Required) The Object Storage namespace used for the request.
+* `object_events_enabled` - (Optional) (Updatable) A property that determines whether events will be generated for operations on objects in this bucket. This is false by default. 
 * `storage_tier` - (Optional) The type of storage tier of this bucket. A bucket is set to 'Standard' tier by default, which means the bucket will be put in the standard storage tier. When 'Archive' tier type is set explicitly, the bucket is put in the Archive Storage tier. The 'storageTier' property is immutable after bucket is created. 
 
 
@@ -66,6 +68,7 @@ The following attributes are exported:
 * `metadata` - Arbitrary string keys and values for user-defined metadata.
 * `name` - The name of the bucket. Avoid entering confidential information. Example: my-new-bucket1 
 * `namespace` - The Object Storage namespace in which the bucket lives.
+* `object_events_enabled` - A property that determines whether events will be generated for operations on objects in this bucket. This is false by default. 
 * `object_lifecycle_policy_etag` - The entity tag (ETag) for the live object lifecycle policy on the bucket.
 * `storage_tier` - The storage tier type assigned to the bucket. A bucket is set to 'Standard' tier by default, which means objects uploaded or copied to the bucket will be in the standard storage tier. When the 'Archive' tier type is set explicitly for a bucket, objects uploaded or copied to the bucket will be stored in archive storage. The 'storageTier' property is immutable after bucket is created. 
 * `time_created` - The date and time the bucket was created, as described in [RFC 2616](https://tools.ietf.org/rfc/rfc2616), section 14.29.