Some working example acceptance tests

Author: mikejihbe

data_source_obmcs_core_console_history_data_test.go

@@ -25,9 +25,6 @@ type CoreConsoleHistoryDataDatasourceTestSuite struct {
 }
 
 func (s *CoreConsoleHistoryDataDatasourceTestSuite) SetupTest() {
-	if IsAccTest() {
-		s.T().Skip()
-	}
 	s.Client = GetTestProvider()
 	s.Provider = Provider(func(d *schema.ResourceData) (interface{}, error) {
 		return s.Client, nil
@@ -37,8 +34,12 @@ func (s *CoreConsoleHistoryDataDatasourceTestSuite) SetupTest() {
 		"baremetal": s.Provider,
 	}
 	s.Config = `
+
+    resource "baremetal_core_console_history" "t" {
+			instance_id = "instance_id"
+    }
     data "baremetal_core_console_history_data" "s" {
-      console_history_id = "ichid"
+      console_history_id = "${baremetal_core_console_history.t.id}"
       length = 1
       offset = 1
     }

data_source_obmcs_core_image_test.go

@@ -40,7 +40,6 @@ func (s *ResourceCoreImagesTestSuite) SetupTest() {
     data "baremetal_core_images" "t" {
       compartment_id = "${var.compartment_id}"
       limit = 1
-      page = "page"
     }
   `
 	s.Config += testProviderConfig()
@@ -69,7 +68,6 @@ func (s *ResourceCoreImagesTestSuite) SetupTest() {
 func (s *ResourceCoreImagesTestSuite) TestReadImages() {
 	opts := &baremetal.ListImagesOptions{}
 	opts.Limit = 1
-	opts.Page = "page"
 
 	s.Client.On("ListImages", "compartment_id", opts).Return(s.List, nil)
 
@@ -82,12 +80,9 @@ func (s *ResourceCoreImagesTestSuite) TestReadImages() {
 				ImportStateVerify: true,
 				Config:            s.Config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(s.ResourceName, "compartment_id", "compartment_id"),
-					resource.TestCheckResourceAttr(s.ResourceName, "limit", "1"),
-					resource.TestCheckResourceAttr(s.ResourceName, "page", "page"),
-					resource.TestCheckResourceAttr(s.ResourceName, "images.0.id", "id1"),
-					resource.TestCheckResourceAttr(s.ResourceName, "images.1.id", "id2"),
-					resource.TestCheckResourceAttr(s.ResourceName, "images.#", "2"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "images.0.id"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "images.1.id"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "images.#"),
 				),
 			},
 		},
@@ -98,6 +93,9 @@ func (s *ResourceCoreImagesTestSuite) TestReadImages() {
 }
 
 func (s *ResourceCoreImagesTestSuite) TestReadImagesWithPagination() {
+	if IsAccTest() {
+		s.T().Skip()
+	}
 	opts := &baremetal.ListImagesOptions{}
 	opts.Limit = 1
 	opts.Page = "page"

data_source_obmcs_core_shape_test.go

@@ -35,10 +35,12 @@ func (s *ResourceCoreShapeTestSuite) SetupTest() {
 		"baremetal": s.Provider,
 	}
 	s.Config = `
+    data "baremetal_identity_availability_domains" "t" {
+      compartment_id = "${var.compartment_id}"
+    }
     data "baremetal_core_shape" "s" {
       compartment_id = "${var.compartment_id}"
-      availability_domain = "availability_domain"
-      image_id = "imageid"
+      availability_domain = "${data.baremetal_identity_availability_domains.t.availability_domains.0.name}"
     }
   `
 	s.Config += testProviderConfig()
@@ -78,12 +80,11 @@ func (s *ResourceCoreShapeTestSuite) TestResourceReadCoreShape() {
 				ImportStateVerify: true,
 				Config:            s.Config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(s.ResourceName, "compartment_id", "compartmentid"),
-					resource.TestCheckResourceAttr(s.ResourceName, "availability_domain", "availability_domain"),
-					resource.TestCheckResourceAttr(s.ResourceName, "image_id", "imageid"),
-					resource.TestCheckResourceAttr(s.ResourceName, "shapes.0.name", "shape1"),
-					resource.TestCheckResourceAttr(s.ResourceName, "shapes.1.name", "shape2"),
-					resource.TestCheckResourceAttr(s.ResourceName, "shapes.#", "2"),
+
+					resource.TestCheckResourceAttrSet(s.ResourceName, "availability_domain"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "shapes.0.name"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "shapes.1.name"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "shapes.#"),
 				),
 			},
 		},
@@ -95,6 +96,9 @@ func (s *ResourceCoreShapeTestSuite) TestResourceReadCoreShape() {
 }
 
 func (s *ResourceCoreShapeTestSuite) TestResourceReadCoreShapeWithPagination() {
+	if IsAccTest() {
+		s.T().Skip()
+	}
 	opts := &baremetal.ListShapesOptions{}
 	opts.AvailabilityDomain = "availability_domain"
 	opts.ImageID = "imageid"
@@ -130,7 +134,7 @@ func (s *ResourceCoreShapeTestSuite) TestResourceReadCoreShapeWithPagination() {
 				ImportStateVerify: true,
 				Config:            s.Config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(s.ResourceName, "compartment_id", "compartmentid"),
+
 					resource.TestCheckResourceAttr(s.ResourceName, "availability_domain", "availability_domain"),
 					resource.TestCheckResourceAttr(s.ResourceName, "image_id", "imageid"),
 					resource.TestCheckResourceAttr(s.ResourceName, "shapes.0.name", "shape1"),

data_source_obmcs_identity_availability_domain_test.go

@@ -55,7 +55,7 @@ func (s *ResourceIdentityAvailabilityDomainsTestSuite) SetupTest() {
 	}
 }
 
-func (s *ResourceIdentityAvailabilityDomainsTestSuite) TestReadAPIKeys() {
+func (s *ResourceIdentityAvailabilityDomainsTestSuite) TestReadAvailabilityDomains() {
 	s.Client.On("ListAvailabilityDomains", "compartmentID").Return(s.List, nil)
 
 	resource.UnitTest(s.T(), resource.TestCase{
@@ -67,18 +67,17 @@ func (s *ResourceIdentityAvailabilityDomainsTestSuite) TestReadAPIKeys() {
 				ImportStateVerify: true,
 				Config:            s.Config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(s.ResourceName, "compartment_id", "CompartmentID"),
-					resource.TestCheckResourceAttr(s.ResourceName, "availability_domains.0.name", "AD1"),
-					resource.TestCheckResourceAttr(s.ResourceName, "availability_domains.1.name", "AD2"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "availability_domains.0.name"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "availability_domains.1.name"),
 				),
 			},
 		},
 	},
 	)
 
-	s.Client.AssertCalled(s.T(), "ListAPIKeys", "user_id")
+	s.Client.AssertCalled(s.T(), "ListAvailabilityDomains", "user_id")
 }
 
 func TestResourceIdentityAvailabilityDomainsTestSuite(t *testing.T) {
-	suite.Run(t, new(ResourceIdentityAPIKeysTestSuite))
+	suite.Run(t, new(ResourceIdentityAvailabilityDomainsTestSuite))
 }

data_source_obmcs_objectstorage_bucketsummary_test.go

@@ -111,7 +111,7 @@ func (s *ObjectstorageBucketSummaryTestSuite) TestReadBucketSummaries() {
 				ImportStateVerify: true,
 				Config:            s.Config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(s.ResourceName, "compartment_id", "compartmentid"),
+
 					resource.TestCheckResourceAttr(s.ResourceName, "namespace", "namespace"),
 					resource.TestCheckResourceAttr(s.ResourceName, "limit", "2"),
 					resource.TestCheckResourceAttr(s.ResourceName, "bucket_summaries.0.name", "name0"),