Skip to content

Commit 3f0dc9e

Browse files
govindrao55govindrao55
committed
fixng netmask in test cases
1 parent c5c910f commit 3f0dc9e

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

‎examples/database/dataguard/existing_vm_cluster/dataguard.tf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ resource "oci_database_vm_cluster_network" "test_vm_cluster_network" {
118118
vm_networks {
119119
domain_name = "oracle.com"
120120
gateway = "192.169.20.2"
121-
netmask = "255.255.0.1"
121+
netmask = "255.255.192.0"
122122
network_type = "BACKUP"
123123

124124
nodes {
@@ -137,7 +137,7 @@ resource "oci_database_vm_cluster_network" "test_vm_cluster_network" {
137137
vm_networks {
138138
domain_name = "oracle.com"
139139
gateway = "192.168.20.2"
140-
netmask = "255.255.0.1"
140+
netmask = "255.255.192.0"
141141
network_type = "CLIENT"
142142

143143
nodes {

‎oci/database_data_guard_association_resource_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ func TestResourceDatabaseDataGuardAssociation_ExadataExistingVMCluster(t *testin
393393
}
394394

395395
func TestResourceDatabaseDataGuardAssociation_ExadataExistingDBHome(t *testing.T) {
396-
httpreplay.SetScenario("TestResourceDatabaseDataGuardAssociation_ExadataExistingVMCluster")
396+
httpreplay.SetScenario("TestResourceDatabaseDataGuardAssociation_ExadataExistingDBHome")
397397
defer httpreplay.SaveScenario()
398398

399399
provider := testAccProvider

‎oci/database_exadata_infrastructure_resource_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ var (
2929
"dns_server": Representation{repType: Required, create: []string{`10.231.225.65`}, update: []string{`10.31.138.25`, `206.223.27.1`}},
3030
"gateway": Representation{repType: Required, create: `10.32.88.5`, update: `10.32.88.6`},
3131
"infini_band_network_cidr": Representation{repType: Required, create: `10.31.8.0/21`, update: `10.31.8.0/22`},
32-
"netmask": Representation{repType: Required, create: `255.255.255.0`, update: `255.254.255.0`},
32+
"netmask": Representation{repType: Required, create: `255.255.255.0`, update: `255.255.254.0`},
3333
"ntp_server": Representation{repType: Required, create: []string{`10.231.225.76`}, update: []string{`10.246.6.36`, `10.31.138.20`}},
3434
"shape": Representation{repType: Required, create: `ExadataCC.Quarter3.100`},
3535
"time_zone": Representation{repType: Required, create: `US/Pacific`, update: `UTC`},
@@ -87,7 +87,7 @@ func TestResourceDatabaseExadataInfrastructure_basic(t *testing.T) {
8787
resource.TestCheckResourceAttr(resourceName, "gateway", "10.32.88.6"),
8888
resource.TestCheckResourceAttrSet(resourceName, "id"),
8989
resource.TestCheckResourceAttr(resourceName, "infini_band_network_cidr", "10.31.8.0/22"),
90-
resource.TestCheckResourceAttr(resourceName, "netmask", "255.254.255.0"),
90+
resource.TestCheckResourceAttr(resourceName, "netmask", "255.255.254.0"),
9191
resource.TestCheckResourceAttr(resourceName, "ntp_server.#", "2"),
9292
resource.TestCheckResourceAttr(resourceName, "shape", "ExadataCC.Quarter3.100"),
9393
resource.TestCheckResourceAttr(resourceName, "time_zone", "UTC"),
@@ -116,7 +116,7 @@ func TestResourceDatabaseExadataInfrastructure_basic(t *testing.T) {
116116
resource.TestCheckResourceAttr(resourceName, "gateway", "10.32.88.6"),
117117
resource.TestCheckResourceAttrSet(resourceName, "id"),
118118
resource.TestCheckResourceAttr(resourceName, "infini_band_network_cidr", "10.31.8.0/22"),
119-
resource.TestCheckResourceAttr(resourceName, "netmask", "255.254.255.0"),
119+
resource.TestCheckResourceAttr(resourceName, "netmask", "255.255.254.0"),
120120
resource.TestCheckResourceAttr(resourceName, "ntp_server.#", "2"),
121121
resource.TestCheckResourceAttr(resourceName, "shape", "ExadataCC.Quarter3.100"),
122122
resource.TestCheckResourceAttr(resourceName, "time_zone", "UTC"),
@@ -146,7 +146,7 @@ func TestResourceDatabaseExadataInfrastructure_basic(t *testing.T) {
146146
resource.TestCheckResourceAttr(resourceName, "gateway", "10.32.88.6"),
147147
resource.TestCheckResourceAttrSet(resourceName, "id"),
148148
resource.TestCheckResourceAttr(resourceName, "infini_band_network_cidr", "10.31.8.0/22"),
149-
resource.TestCheckResourceAttr(resourceName, "netmask", "255.254.255.0"),
149+
resource.TestCheckResourceAttr(resourceName, "netmask", "255.255.254.0"),
150150
resource.TestCheckResourceAttr(resourceName, "ntp_server.#", "2"),
151151
resource.TestCheckResourceAttr(resourceName, "shape", "ExadataCC.Quarter3.100"),
152152
resource.TestCheckResourceAttr(resourceName, "time_zone", "UTC"),

‎oci/database_exadata_infrastructure_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ var (
4949
"dns_server": Representation{repType: Required, create: []string{`10.231.225.65`}, update: []string{`10.31.138.25`, `206.223.27.1`}},
5050
"gateway": Representation{repType: Required, create: `10.32.88.5`, update: `10.32.88.6`},
5151
"infini_band_network_cidr": Representation{repType: Required, create: `10.31.8.0/21`, update: `10.31.8.0/22`},
52-
"netmask": Representation{repType: Required, create: `255.255.255.0`, update: `255.254.255.0`},
52+
"netmask": Representation{repType: Required, create: `255.255.255.0`, update: `255.255.254.0`},
5353
"ntp_server": Representation{repType: Required, create: []string{`10.231.225.76`}, update: []string{`10.246.6.36`, `10.31.138.20`}},
5454
"shape": Representation{repType: Required, create: `ExadataCC.Quarter3.100`},
5555
"time_zone": Representation{repType: Required, create: `US/Pacific`, update: `UTC`},
@@ -226,7 +226,7 @@ func TestDatabaseExadataInfrastructureResource_basic(t *testing.T) {
226226
resource.TestCheckResourceAttr(resourceName, "gateway", "10.32.88.6"),
227227
resource.TestCheckResourceAttrSet(resourceName, "id"),
228228
resource.TestCheckResourceAttr(resourceName, "infini_band_network_cidr", "10.31.8.0/22"),
229-
resource.TestCheckResourceAttr(resourceName, "netmask", "255.254.255.0"),
229+
resource.TestCheckResourceAttr(resourceName, "netmask", "255.255.254.0"),
230230
resource.TestCheckResourceAttr(resourceName, "ntp_server.#", "2"),
231231
resource.TestCheckResourceAttr(resourceName, "shape", "ExadataCC.Quarter3.100"),
232232
resource.TestCheckResourceAttrSet(resourceName, "state"),
@@ -279,7 +279,7 @@ func TestDatabaseExadataInfrastructureResource_basic(t *testing.T) {
279279
resource.TestCheckResourceAttrSet(datasourceName, "exadata_infrastructures.0.max_db_node_storage_in_gbs"),
280280
resource.TestCheckResourceAttrSet(datasourceName, "exadata_infrastructures.0.max_memory_in_gbs"),
281281
resource.TestCheckResourceAttrSet(datasourceName, "exadata_infrastructures.0.memory_size_in_gbs"),
282-
resource.TestCheckResourceAttr(datasourceName, "exadata_infrastructures.0.netmask", "255.254.255.0"),
282+
resource.TestCheckResourceAttr(datasourceName, "exadata_infrastructures.0.netmask", "255.255.254.0"),
283283
resource.TestCheckResourceAttr(datasourceName, "exadata_infrastructures.0.ntp_server.#", "2"),
284284
resource.TestCheckResourceAttr(datasourceName, "exadata_infrastructures.0.shape", "ExadataCC.Quarter3.100"),
285285
resource.TestCheckResourceAttrSet(datasourceName, "exadata_infrastructures.0.state"),
@@ -318,7 +318,7 @@ func TestDatabaseExadataInfrastructureResource_basic(t *testing.T) {
318318
resource.TestCheckResourceAttrSet(singularDatasourceName, "id"),
319319
resource.TestCheckResourceAttr(singularDatasourceName, "infini_band_network_cidr", "10.31.8.0/22"),
320320
resource.TestCheckResourceAttrSet(singularDatasourceName, "memory_size_in_gbs"),
321-
resource.TestCheckResourceAttr(singularDatasourceName, "netmask", "255.254.255.0"),
321+
resource.TestCheckResourceAttr(singularDatasourceName, "netmask", "255.255.254.0"),
322322
resource.TestCheckResourceAttr(singularDatasourceName, "ntp_server.#", "2"),
323323
resource.TestCheckResourceAttr(singularDatasourceName, "shape", "ExadataCC.Quarter3.100"),
324324
resource.TestCheckResourceAttrSet(singularDatasourceName, "state"),

‎oci/database_vm_cluster_network_resource_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func TestResourceDatabaseVmClusterNetwork_basic(t *testing.T) {
8585
CheckResourceSetContainsElementWithProperties(resourceName, "vm_networks", map[string]string{
8686
"domain_name": "oracle.com",
8787
"gateway": "192.169.20.2",
88-
"netmask": "255.255.0.1",
88+
"netmask": "255.255.192.0",
8989
"network_type": "BACKUP",
9090
"nodes.#": "2",
9191
},
@@ -123,7 +123,7 @@ func TestResourceDatabaseVmClusterNetwork_basic(t *testing.T) {
123123
CheckResourceSetContainsElementWithProperties(resourceName, "vm_networks", map[string]string{
124124
"domain_name": "oracle.com",
125125
"gateway": "192.169.20.2",
126-
"netmask": "255.255.0.1",
126+
"netmask": "255.255.192.0",
127127
"network_type": "BACKUP",
128128
"nodes.#": "2",
129129
},
@@ -161,7 +161,7 @@ func TestResourceDatabaseVmClusterNetwork_basic(t *testing.T) {
161161
CheckResourceSetContainsElementWithProperties(resourceName, "vm_networks", map[string]string{
162162
"domain_name": "oracle.com",
163163
"gateway": "192.169.20.2",
164-
"netmask": "255.255.0.1",
164+
"netmask": "255.255.192.0",
165165
"network_type": "BACKUP",
166166
"nodes.#": "2",
167167
},

‎oci/database_vm_cluster_network_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@ var (
6161
vmClusterNetworkBackupVmNetworkRepresentation = map[string]interface{}{
6262
"domain_name": Representation{repType: Required, create: `oracle.com`, update: `oracle.com`},
6363
"gateway": Representation{repType: Required, create: `192.169.20.1`, update: `192.169.20.2`},
64-
"netmask": Representation{repType: Required, create: `255.255.0.0`, update: `255.255.0.1`},
64+
"netmask": Representation{repType: Required, create: `255.255.0.0`, update: `255.255.192.0`},
6565
"network_type": Representation{repType: Required, create: `BACKUP`, update: `BACKUP`},
6666
"nodes": []RepresentationGroup{{Required, vmClusterNetworkVmNetworksBackupNodes1Representation}, {Required, vmClusterNetworkVmNetworksBackupNodes2Representation}},
6767
"vlan_id": Representation{repType: Required, create: `100`},
6868
}
6969
vmClusterNetworkClientVmNetworkRepresentation = map[string]interface{}{
7070
"domain_name": Representation{repType: Required, create: `oracle.com`, update: `oracle.com`},
7171
"gateway": Representation{repType: Required, create: `192.168.20.1`, update: `192.168.20.2`},
72-
"netmask": Representation{repType: Required, create: `255.255.0.0`, update: `255.255.0.1`},
72+
"netmask": Representation{repType: Required, create: `255.255.0.0`, update: `255.255.192.0`},
7373
"network_type": Representation{repType: Required, create: `CLIENT`, update: `CLIENT`},
7474
"nodes": []RepresentationGroup{{Required, vmClusterNetworkVmNetworksClientNodes1Representation}, {Required, vmClusterNetworkVmNetworksClientNodes2Representation}},
7575
"vlan_id": Representation{repType: Required, create: `101`},
@@ -231,7 +231,7 @@ func TestDatabaseVmClusterNetworkResource_basic(t *testing.T) {
231231
CheckResourceSetContainsElementWithProperties(resourceName, "vm_networks", map[string]string{
232232
"domain_name": "oracle.com",
233233
"gateway": "192.169.20.2",
234-
"netmask": "255.255.0.1",
234+
"netmask": "255.255.192.0",
235235
"network_type": "BACKUP",
236236
"nodes.#": "2",
237237
},
@@ -282,7 +282,7 @@ func TestDatabaseVmClusterNetworkResource_basic(t *testing.T) {
282282
CheckResourceSetContainsElementWithProperties(datasourceName, "vm_cluster_networks.0.vm_networks", map[string]string{
283283
"domain_name": "oracle.com",
284284
"gateway": "192.169.20.2",
285-
"netmask": "255.255.0.1",
285+
"netmask": "255.255.192.0",
286286
"network_type": "BACKUP",
287287
"nodes.#": "2",
288288
},
@@ -320,7 +320,7 @@ func TestDatabaseVmClusterNetworkResource_basic(t *testing.T) {
320320
CheckResourceSetContainsElementWithProperties(singularDatasourceName, "vm_networks", map[string]string{
321321
"domain_name": "oracle.com",
322322
"gateway": "192.169.20.2",
323-
"netmask": "255.255.0.1",
323+
"netmask": "255.255.192.0",
324324
"network_type": "BACKUP",
325325
"nodes.#": "2",
326326
},

0 commit comments

Comments
 (0)