Skip to content

Commit 495e48a

Browse files
afedorchalexng-canuck
authored andcommitted
Adding client configuration for the source clients
1 parent 352c8b4 commit 495e48a

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed

oci/helpers_core.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,15 @@ func getBackupPolicyId(assetId *string, client *oci_core.BlockstorageClient) (*s
7777

7878
func (s *VolumeBackupResourceCrud) createBlockStorageSourceRegionClient(region string) error {
7979
if s.SourceRegionClient == nil {
80-
sourceObjectStorageClient, err := oci_core.NewBlockstorageClientWithConfigurationProvider(*s.Client.ConfigurationProvider())
80+
sourceBlockStorageClient, err := oci_core.NewBlockstorageClientWithConfigurationProvider(*s.Client.ConfigurationProvider())
8181
if err != nil {
8282
return fmt.Errorf("cannot create client for the source region: %v", err)
8383
}
84-
s.SourceRegionClient = &sourceObjectStorageClient
84+
err = configureClient(&sourceBlockStorageClient.BaseClient)
85+
if err != nil {
86+
return fmt.Errorf("cannot configure client for the source region: %v", err)
87+
}
88+
s.SourceRegionClient = &sourceBlockStorageClient
8589
}
8690
s.SourceRegionClient.SetRegion(region)
8791

oci/helpers_core_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,19 @@ func createVolumeInRegion(clients *OracleClients, region string) (string, error)
1818
if err != nil {
1919
return "", fmt.Errorf("cannot create client for the source region %s: %v", region, err)
2020
}
21+
err = configureClient(&blockStorageClient.BaseClient)
22+
if err != nil {
23+
return "", fmt.Errorf("cannot configure client for the source region: %v", err)
24+
}
2125
blockStorageClient.SetRegion(region)
2226
identityClient, err := oci_identity.NewIdentityClientWithConfigurationProvider(*clients.identityClient.ConfigurationProvider())
2327
if err != nil {
2428
return "", fmt.Errorf("cannot create client for the source region %s: %v", region, err)
2529
}
30+
err = configureClient(&identityClient.BaseClient)
31+
if err != nil {
32+
return "", fmt.Errorf("cannot configure client for the source region: %v", err)
33+
}
2634
identityClient.SetRegion(region)
2735
listAvailabilityDomainsResponse, err := identityClient.ListAvailabilityDomains(context.Background(),
2836
oci_identity.ListAvailabilityDomainsRequest{
@@ -69,6 +77,10 @@ func createVolumeBackupInRegion(clients *OracleClients, region string, volumeId
6977
if err != nil {
7078
return "", fmt.Errorf("cannot create client for the source region %s: %v", region, err)
7179
}
80+
err = configureClient(&blockStorageClient.BaseClient)
81+
if err != nil {
82+
return "", fmt.Errorf("cannot configure client for the source region: %v", err)
83+
}
7284
blockStorageClient.SetRegion(region)
7385

7486
createVolumeBackupResponse, err := blockStorageClient.CreateVolumeBackup(context.Background(), oci_core.CreateVolumeBackupRequest{
@@ -104,6 +116,10 @@ func deleteVolumeInRegion(clients *OracleClients, region string, volumeId string
104116
if err != nil {
105117
return fmt.Errorf("cannot create client for the source region %s: %v", region, err)
106118
}
119+
err = configureClient(&blockStorageClient.BaseClient)
120+
if err != nil {
121+
return fmt.Errorf("cannot configure client for the source region: %v", err)
122+
}
107123
blockStorageClient.SetRegion(region)
108124

109125
if volumeId != "" {
@@ -125,6 +141,10 @@ func deleteVolumeBackupInRegion(clients *OracleClients, region string, volumeBac
125141
if err != nil {
126142
return fmt.Errorf("cannot create client for the source region %s: %v", region, err)
127143
}
144+
err = configureClient(&blockStorageClient.BaseClient)
145+
if err != nil {
146+
return fmt.Errorf("cannot configure client for the source region: %v", err)
147+
}
128148
blockStorageClient.SetRegion(region)
129149

130150
if volumeBackupId != "" {

oci/helpers_objectstorage.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,10 @@ func (s *ObjectResourceCrud) createSourceRegionClient(region string) error {
403403
if err != nil {
404404
return fmt.Errorf("cannot create client for the source region: %v", err)
405405
}
406+
err = configureClient(&sourceObjectStorageClient.BaseClient)
407+
if err != nil {
408+
return fmt.Errorf("cannot configure client for the source region: %v", err)
409+
}
406410
s.SourceRegionClient = &sourceObjectStorageClient
407411
}
408412
s.SourceRegionClient.SetRegion(region)

0 commit comments

Comments
 (0)