Skip to content

Commit 4a76161

Browse files
wynnewangganbaras
authored andcommitted
Bug Fix - IdentityDomains fixes for App resource; Doc update for User, Group
1 parent c7d0abc commit 4a76161

30 files changed

+922
-263
lines changed

examples/identity_domains/app.tf

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ variable "app_urnietfparamsscimschemasoracleidcsextensionmanagedapp_app_three_le
10421042
}
10431043

10441044
variable "app_urnietfparamsscimschemasoracleidcsextensionmanagedapp_app_three_legged_oauth_credential_access_token_expiry" {
1045-
default = "2032-01-01T00:00:00Z"
1045+
default = "2032-01-01T00:00:00.000Z"
10461046
}
10471047

10481048
variable "app_urnietfparamsscimschemasoracleidcsextensionmanagedapp_app_three_legged_oauth_credential_refresh_token" {
@@ -1380,6 +1380,8 @@ resource "oci_identity_domains_app" "test_app" {
13801380
description = var.app_description
13811381
disable_kmsi_token_authentication = var.app_disable_kmsi_token_authentication
13821382
error_page_url = var.app_error_page_url
1383+
## If set "force_delete" to true, `terraform destory` will be able to force delete the resource.
1384+
force_delete = true
13831385
home_page_url = var.app_home_page_url
13841386
icon = var.app_icon
13851387
id_token_enc_algo = var.app_id_token_enc_algo

examples/identity_domains/auth_token.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ variable "auth_token_description" {
1414
}
1515

1616
variable "auth_token_expires_on" {
17-
default = "2030-01-01T00:00:00Z"
17+
default = "2030-01-01T00:00:00.000Z"
1818
}
1919

2020
variable "auth_token_start_index" {

examples/identity_domains/authentication_factor_settings.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ variable "authentication_factor_setting_endpoint_restrictions_trusted_endpoints_
130130
}
131131

132132
variable "authentication_factor_setting_fido_authenticator_enabled" {
133-
default = false
133+
default = true
134134
}
135135

136136
variable "authentication_factor_setting_hide_backup_factor_enabled" {
@@ -158,15 +158,15 @@ variable "authentication_factor_setting_phone_call_enabled" {
158158
}
159159

160160
variable "authentication_factor_setting_push_enabled" {
161-
default = false
161+
default = true
162162
}
163163

164164
variable "authentication_factor_setting_security_questions_enabled" {
165165
default = false
166166
}
167167

168168
variable "authentication_factor_setting_sms_enabled" {
169-
default = "true"
169+
default = false
170170
}
171171

172172
variable "authentication_factor_setting_tags_key" {
@@ -186,7 +186,7 @@ variable "authentication_factor_setting_third_party_factor_duo_security" {
186186
}
187187

188188
variable "authentication_factor_setting_totp_enabled" {
189-
default = false
189+
default = true
190190
}
191191

192192
variable "authentication_factor_setting_totp_settings_email_otp_validity_duration_in_mins" {

examples/identity_domains/customer_secret_key.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ variable "customer_secret_key_display_name" {
1818
}
1919

2020
variable "customer_secret_key_expires_on" {
21-
default = "2030-01-01T00:00:00Z"
21+
default = "2030-01-01T00:00:00.000Z"
2222
}
2323

2424
variable "customer_secret_key_start_index" {

examples/identity_domains/grant.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ resource "oci_identity_domains_user" "test_grant_user" {
5555
}
5656
}
5757

58+
### An test app to test grant
5859
data "oci_identity_domains_apps" "test_grant_apps" {
5960
idcs_endpoint = data.oci_identity_domain.test_domain.url
6061
app_filter = "displayName sw \"GrantTestApp\""

examples/identity_domains/group.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ resource "oci_identity_domains_group" "test_group" {
133133
attributes = ""
134134
authorization = var.group_authorization
135135
external_id = "externalId"
136+
## If set "force_delete" to true, `terraform destory` will be able to force delete the resource.
137+
force_delete = true
136138
/* #provide user's id and/or ocid to add to this group
137139
members {
138140
#Required

examples/identity_domains/identity_propagation_trust.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,12 @@ resource "oci_identity_domains_user" "test_identity_propagation_trust_user" {
107107
primary = true
108108
}
109109

110+
emails {
111+
#Required
112+
type = "recovery"
113+
114+
}
115+
110116
lifecycle {
111117
ignore_changes = [schemas]
112118
}

examples/identity_domains/my_auth_token.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ variable "my_auth_token_description" {
1818
}
1919

2020
variable "my_auth_token_expires_on" {
21-
default = "2030-01-01T00:00:00Z"
21+
default = "2030-01-01T00:00:00.000Z"
2222
}
2323

2424
variable "my_auth_token_start_index" {

examples/identity_domains/my_customer_secret_key.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ variable "my_customer_secret_key_display_name" {
2626
}
2727

2828
variable "my_customer_secret_key_expires_on" {
29-
default = "2030-01-01T00:00:00Z"
29+
default = "2030-01-01T00:00:00.000Z"
3030
}
3131

3232
variable "my_customer_secret_key_start_index" {

examples/identity_domains/my_oauth2client_credential.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ variable "my_oauth2client_credential_description" {
1818
}
1919

2020
variable "my_oauth2client_credential_expires_on" {
21-
default = "2030-01-01T00:00:00Z"
21+
default = "2030-01-01T00:00:00.000Z"
2222
}
2323

2424
variable "my_oauth2client_credential_is_reset_secret" {

0 commit comments

Comments
 (0)