Bug Fix - Fix assignPublicIp mapping in core_instance_configuration_resource

Author: abrafi2024

examples/compute/instance_pool/instance_configuration.tf

@@ -2,7 +2,7 @@ variable "windows_instance_shape" {
   default = "VM.Standard2.1"
 }
 
-resource "oci_core_instance_configuration" "test_instance_configuration" {
+resource "oci_core_instance_configuration" "test_instance_config" {
   compartment_id = var.compartment_ocid
   display_name   = "TestInstanceConfiguration"
 

examples/compute/instance_pool/instance_pool.tf

@@ -325,11 +325,12 @@ data "oci_core_instance_pools" "test_instance_pools_datasource" {
 data "oci_core_instance_pool_instances" "test_instance_pool_instances_datasource" {
   compartment_id   = var.compartment_ocid
   instance_pool_id = oci_core_instance_pool.test_instance_pool.id
+  depends_on = [oci_core_instance_pool_instance.test_instance_pool_instance]
 }
 
 # Usage of singular instance datasources to show the public_ips, private_ips, and hostname_labels for the instances in the pool
 data "oci_core_instance" "test_instance_pool_instance_singular_datasource" {
-  count       = 2
+  count       = 3
   instance_id = data.oci_core_instance_pool_instances.test_instance_pool_instances_datasource.instances[count.index]["id"]
 }
 

internal/service/core/core_instance_configuration_resource.go

@@ -3071,6 +3071,9 @@ func (s *CoreInstanceConfigurationResourceCrud) mapToInstanceConfigurationCreate
 	if assignPublicIp, ok := s.D.GetOkExists(fmt.Sprintf(fieldKeyFormat, "assign_public_ip")); ok {
 		tmp := assignPublicIp.(bool)
 		result.AssignPublicIp = &tmp
+	} else {
+		t := true
+		result.AssignPublicIp = &t
 	}
 
 	if definedTags, ok := s.D.GetOkExists(fmt.Sprintf(fieldKeyFormat, "defined_tags")); ok {