Skip to content

Commit 5a403e8

Browse files
committed
disabling compartment export on keystore resource for pending upstream change
1 parent 646a9ca commit 5a403e8

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
### Added
44
- Support for reading OBO token from local file
5+
- Support for Oracle Key Vault with ExaCC
56

67
## 4.0.0 (October 21, 2020)
78

oci/database_key_store_resource.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ func DatabaseKeyStoreResource() *schema.Resource {
3434
"compartment_id": {
3535
Type: schema.TypeString,
3636
Required: true,
37+
ForceNew: true,
3738
},
3839
"display_name": {
3940
Type: schema.TypeString,
@@ -266,15 +267,15 @@ func (s *DatabaseKeyStoreResourceCrud) Get() error {
266267
}
267268

268269
func (s *DatabaseKeyStoreResourceCrud) Update() error {
269-
if compartment, ok := s.D.GetOkExists("compartment_id"); ok && s.D.HasChange("compartment_id") {
270+
/*if compartment, ok := s.D.GetOkExists("compartment_id"); ok && s.D.HasChange("compartment_id") {
270271
oldRaw, newRaw := s.D.GetChange("compartment_id")
271272
if newRaw != "" && oldRaw != "" {
272273
err := s.updateCompartment(compartment)
273274
if err != nil {
274275
return err
275276
}
276277
}
277-
}
278+
}*/
278279
request := oci_database.UpdateKeyStoreRequest{}
279280

280281
if definedTags, ok := s.D.GetOkExists("defined_tags"); ok {

oci/database_key_store_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ func TestDatabaseKeyStoreResource_basic(t *testing.T) {
6969
compartmentId := getEnvSettingWithBlankDefault("compartment_ocid")
7070
compartmentIdVariableStr := fmt.Sprintf("variable \"compartment_id\" { default = \"%s\" }\n", compartmentId)
7171

72-
compartmentIdU := getEnvSettingWithDefault("compartment_id_for_update", compartmentId)
73-
compartmentIdUVariableStr := fmt.Sprintf("variable \"compartment_id_for_update\" { default = \"%s\" }\n", compartmentIdU)
72+
//compartmentIdU := getEnvSettingWithDefault("compartment_id_for_update", compartmentId)
73+
//compartmentIdUVariableStr := fmt.Sprintf("variable \"compartment_id_for_update\" { default = \"%s\" }\n", compartmentIdU)
7474

7575
resourceName := "oci_database_key_store.test_key_store"
7676
datasourceName := "data.oci_database_key_stores.test_key_stores"
@@ -139,7 +139,7 @@ func TestDatabaseKeyStoreResource_basic(t *testing.T) {
139139
},
140140

141141
// verify update to the compartment (the compartment will be switched back in the next step)
142-
{
142+
/*{
143143
Config: config + compartmentIdVariableStr + compartmentIdUVariableStr + KeyStoreResourceDependencies +
144144
generateResourceFromRepresentationMap("oci_database_key_store", "test_key_store", Optional, Create,
145145
representationCopyWithNewProperties(keyStoreRepresentation, map[string]interface{}{
@@ -166,7 +166,7 @@ func TestDatabaseKeyStoreResource_basic(t *testing.T) {
166166
return err
167167
},
168168
),
169-
},
169+
},*/
170170

171171
// verify updates to updatable parameters
172172
{

website/docs/r/database_key_store.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ resource "oci_database_key_store" "test_key_store" {
4040

4141
The following arguments are supported:
4242

43-
* `compartment_id` - (Required) (Updatable) The [OCID](https://docs.cloud.oracle.com/iaas/Content/General/Concepts/identifiers.htm) of the compartment.
43+
* `compartment_id` - (Required) The [OCID](https://docs.cloud.oracle.com/iaas/Content/General/Concepts/identifiers.htm) of the compartment.
4444
* `defined_tags` - (Optional) (Updatable) Defined tags for this resource. Each key is predefined and scoped to a namespace. For more information, see [Resource Tags](https://docs.cloud.oracle.com/iaas/Content/General/Concepts/resourcetags.htm).
4545
* `display_name` - (Required) The user-friendly name for the key store. The name does not need to be unique.
4646
* `freeform_tags` - (Optional) (Updatable) Free-form tags for this resource. Each tag is a simple key-value pair with no predefined name, type, or namespace. For more information, see [Resource Tags](https://docs.cloud.oracle.com/iaas/Content/General/Concepts/resourcetags.htm). Example: `{"Department": "Finance"}`

0 commit comments

Comments
 (0)