Add computed field for maintenance reboot times in instances

Author: alexng-canuck

CHANGELOG.md

@@ -10,7 +10,8 @@
 - Support for encrypting the contents of an Object Storage bucket using a Key Management Service key
 - Support for specifying a Key Management Service key when launching a compute instance in the Compute service
 - Support for specifying a Key Management Service key when backing up or restoring a block storage volume in the Block Volume service
-- Support for cost tracking in tags
+- Support enabling cost tracking for tags using `is_cost_tracking` field
+- Support returning maintenance reboot time for compute instances using `time_maintenance_reboot_due` field
 
 ### Fixed
 - Data type for properties with type as TypeSet to TypeList in following datasources: `oci_core_route_tables`, `oci_core_security_lists`, `oci_core_volume`, and `oci_core_service_gateways` to allow referencing by indexes in Terraform configs.

oci/core_instance_data_source.go

@@ -156,6 +156,10 @@ func InstanceDataSource() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"time_maintenance_reboot_due": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 			// Legacy custom computed convenience values
 			"public_ip": {
 				Type:     schema.TypeString,
@@ -323,6 +327,10 @@ func (s *InstanceDataSourceCrud) SetData() error {
 		s.D.Set("time_created", s.Res.TimeCreated.String())
 	}
 
+	if s.Res.TimeMaintenanceRebootDue != nil {
+		s.D.Set("time_maintenance_reboot_due", s.Res.TimeMaintenanceRebootDue.String())
+	}
+
 	if s.Res.LifecycleState == oci_core.InstanceLifecycleStateRunning {
 		vnic, vnicError := s.getPrimaryVnic()
 		if vnicError != nil || vnic == nil {

oci/core_instance_resource.go

@@ -300,6 +300,10 @@ func InstanceResource() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"time_maintenance_reboot_due": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 			// Legacy custom computed convenience values
 			"public_ip": {
 				Type:     schema.TypeString,
@@ -707,6 +711,14 @@ func (s *InstanceResourceCrud) SetData() error {
 		s.D.Set("time_created", s.Res.TimeCreated.String())
 	}
 
+	if s.Res.TimeMaintenanceRebootDue != nil {
+		s.D.Set("time_maintenance_reboot_due", s.Res.TimeMaintenanceRebootDue.String())
+	} else {
+		// If the maintenance time is cleared after reboot, the service will return a nil. 
+		// We should explicitly zero it out to avoid returning the previously cached reboot time.
+		s.D.Set("time_maintenance_reboot_due", "")
+	}
+
 	if s.Res.LifecycleState == oci_core.InstanceLifecycleStateRunning {
 		vnic, vnicError := s.getPrimaryVnic()
 		if vnicError != nil || vnic == nil {

oci/core_instances_data_source.go

@@ -196,6 +196,10 @@ func (s *InstancesDataSourceCrud) SetData() error {
 			instance["time_created"] = r.TimeCreated.String()
 		}
 
+		if r.TimeMaintenanceRebootDue != nil {
+			instance["time_maintenance_reboot_due"] = r.TimeMaintenanceRebootDue.String()
+		}
+
 		resources = append(resources, instance)
 	}
 

website/docs/d/core_instance.html.markdown

@@ -100,4 +100,5 @@ The following attributes are exported:
 	* `source_type` - The source type for the instance. Use `image` when specifying the image OCID. Use `bootVolume` when specifying the boot volume OCID. 
 * `state` - The current state of the instance.
 * `time_created` - The date and time the instance was created, in the format defined by RFC3339.  Example: `2016-08-25T21:10:29.600Z` 
+* `time_maintenance_reboot_due` - The date and time the instance is expected to be stopped / started,  in the format defined by RFC3339. After that time if instance hasn't been rebooted, Oracle will reboot the instance within 24 hours of the due time. Regardless of how the instance was stopped, the flag will be reset to empty as soon as instance reaches Stopped state. Example: `2018-05-25T21:10:29.600Z` 
 

website/docs/d/core_instances.html.markdown

@@ -112,4 +112,5 @@ The following attributes are exported:
 	* `source_type` - The source type for the instance. Use `image` when specifying the image OCID. Use `bootVolume` when specifying the boot volume OCID. 
 * `state` - The current state of the instance.
 * `time_created` - The date and time the instance was created, in the format defined by RFC3339.  Example: `2016-08-25T21:10:29.600Z` 
+* `time_maintenance_reboot_due` - The date and time the instance is expected to be stopped / started,  in the format defined by RFC3339. After that time if instance hasn't been rebooted, Oracle will reboot the instance within 24 hours of the due time. Regardless of how the instance was stopped, the flag will be reset to empty as soon as instance reaches Stopped state. Example: `2018-05-25T21:10:29.600Z` 
 

website/docs/r/core_instance.html.markdown

@@ -132,6 +132,8 @@ The following arguments are supported:
 
 	If you do not specify the fault domain, the system selects one for you. To change the fault domain for an instance, terminate it and launch a new instance in the preferred fault domain.
 
+	To get a list of fault domains, use the [ListFaultDomains](https://docs.cloud.oracle.com/iaas/api/#/en/identity/20160918/FaultDomain/ListFaultDomains) operation in the Identity and Access Management Service API.
+
 	Example: `FAULT-DOMAIN-1` 
 * `freeform_tags` - (Optional) (Updatable) Free-form tags for this resource. Each tag is a simple key-value pair with no predefined name, type, or namespace. For more information, see [Resource Tags](https://docs.cloud.oracle.com/iaas/Content/General/Concepts/resourcetags.htm).  Example: `{"Department": "Finance"}` 
 * `hostname_label` - (Optional) Deprecated. Instead use `hostnameLabel` in [CreateVnicDetails](https://docs.cloud.oracle.com/iaas/api/#/en/iaas/20160918/CreateVnicDetails/). If you provide both, the values must match. 
@@ -264,6 +266,7 @@ The following attributes are exported:
 	* `source_type` - The source type for the instance. Use `image` when specifying the image OCID. Use `bootVolume` when specifying the boot volume OCID. 
 * `state` - The current state of the instance.
 * `time_created` - The date and time the instance was created, in the format defined by RFC3339.  Example: `2016-08-25T21:10:29.600Z` 
+* `time_maintenance_reboot_due` - The date and time the instance is expected to be stopped / started,  in the format defined by RFC3339. After that time if instance hasn't been rebooted, Oracle will reboot the instance within 24 hours of the due time. Regardless of how the instance was stopped, the flag will be reset to empty as soon as instance reaches Stopped state. Example: `2018-05-25T21:10:29.600Z` 
 
 ## Import