Implement the proper interface of the SDK. Add a test so future builds will detect that any SDK injected properly implements the interface expected

Author: mikejihbe

client/bare_metal_client.go

@@ -22,7 +22,7 @@ type BareMetalClient interface {
 	CreateImage(compartmentID, instanceID string, opts *baremetal.CreateOptions) (res *baremetal.Image, e error)
 	CreateInternetGateway(compartmentID, vcnID string, isEnabled bool, opts *baremetal.CreateOptions) (gw *baremetal.InternetGateway, e error)
 	CreateOrResetUIPassword(userID string, opts *baremetal.RetryTokenOptions) (resource *baremetal.UIPassword, e error)
-	CreatePolicy(name, desc string, statements []string, opts *baremetal.CreatePolicyOptions) (res *baremetal.Policy, e error)
+	CreatePolicy(name, desc, compartmentID string, statements []string, opts *baremetal.CreatePolicyOptions) (res *baremetal.Policy, e error)
 	CreateRouteTable(compartmentID, vcnID string, routeRules []baremetal.RouteRule, opts *baremetal.CreateOptions) (res *baremetal.RouteTable, e error)
 	CreateSecurityList(compartmentID, vcnID string, egressRules []baremetal.EgressSecurityRule, ingressRules []baremetal.IngressSecurityRule, opts *baremetal.CreateOptions) (res *baremetal.SecurityList, e error)
 	CreateSubnet(availabilityDomain, cidrBlock, compartmentID, vcnID string, opts *baremetal.CreateSubnetOptions) (sn *baremetal.Subnet, e error)

client/mocks/bare_metal_client.go

@@ -1,10 +1,8 @@
-// Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
-
 package mocks
 
-import "github.com/stretchr/testify/mock"
-
-import "github.com/MustWin/baremetal-sdk-go"
+import baremetal "github.com/MustWin/baremetal-sdk-go"
+import client "github.com/MustWin/terraform-Oracle-BareMetal-Provider/client"
+import mock "github.com/stretchr/testify/mock"
 
 // BareMetalClient is an autogenerated mock type for the BareMetalClient type
 type BareMetalClient struct {
@@ -333,22 +331,22 @@ func (_m *BareMetalClient) CreateOrResetUIPassword(userID string, opts *baremeta
 	return r0, r1
 }
 
-// CreatePolicy provides a mock function with given fields: name, desc, statements, opts
-func (_m *BareMetalClient) CreatePolicy(name string, desc string, statements []string, opts *baremetal.CreatePolicyOptions) (*baremetal.Policy, error) {
-	ret := _m.Called(name, desc, statements, opts)
+// CreatePolicy provides a mock function with given fields: name, desc, compartmentID, statements, opts
+func (_m *BareMetalClient) CreatePolicy(name string, desc string, compartmentID string, statements []string, opts *baremetal.CreatePolicyOptions) (*baremetal.Policy, error) {
+	ret := _m.Called(name, desc, compartmentID, statements, opts)
 
 	var r0 *baremetal.Policy
-	if rf, ok := ret.Get(0).(func(string, string, []string, *baremetal.CreatePolicyOptions) *baremetal.Policy); ok {
-		r0 = rf(name, desc, statements, opts)
+	if rf, ok := ret.Get(0).(func(string, string, string, []string, *baremetal.CreatePolicyOptions) *baremetal.Policy); ok {
+		r0 = rf(name, desc, compartmentID, statements, opts)
 	} else {
 		if ret.Get(0) != nil {
 			r0 = ret.Get(0).(*baremetal.Policy)
 		}
 	}
 
 	var r1 error
-	if rf, ok := ret.Get(1).(func(string, string, []string, *baremetal.CreatePolicyOptions) error); ok {
-		r1 = rf(name, desc, statements, opts)
+	if rf, ok := ret.Get(1).(func(string, string, string, []string, *baremetal.CreatePolicyOptions) error); ok {
+		r1 = rf(name, desc, compartmentID, statements, opts)
 	} else {
 		r1 = ret.Error(1)
 	}
@@ -2779,3 +2777,5 @@ func (_m *BareMetalClient) UploadAPIKey(userID string, key string, opts *baremet
 
 	return r0, r1
 }
+
+var _ client.BareMetalClient = (*BareMetalClient)(nil)

client_test.go

@@ -0,0 +1,17 @@
+package main
+
+import (
+	"github.com/MustWin/baremetal-sdk-go"
+	"github.com/MustWin/terraform-Oracle-BareMetal-Provider/client"
+	"github.com/stretchr/testify/suite"
+)
+
+type ResourceClientTestSuite struct {
+	suite.Suite
+}
+
+func (s *ResourceClientTestSuite) TestClientInit() {
+	var c client.BareMetalClient
+	c = &baremetal.Client{}
+	s.Require().True(c != nil) // This won't compile if it's not
+}