Policy resource version_date bug fix

* converts field to string to obivate date format disagreement
* add test case
* unrelated addition to policy example for usage clarification

Author: ccushing

docs/examples/iam/policy/policy.tf

@@ -31,11 +31,16 @@ resource "oci_identity_policy" "t" {
   name = "TFExamplePolicy"
   description = "automated test policy"
   compartment_id = "${oci_identity_compartment.t.id}"
-  statements = ["Allow group ${oci_identity_group.t.name} to read instances in compartment ${oci_identity_compartment.t.name}"]
+  statements = ["Allow group ${oci_identity_group.t.name} to inspect instances in compartment ${oci_identity_compartment.t.name}",
+                "Allow group ${oci_identity_group.t.name} to read instances in compartment ${oci_identity_compartment.t.name}"]
 }
 
 data "oci_identity_policies" "p" {
   compartment_id = "${oci_identity_compartment.t.id}"
+  filter {
+    name = "name"
+    values = ["TFExamplePolicy"]
+  }
 }
 
 output "policy" {

provider/identity_policies_data_source.go

@@ -113,6 +113,7 @@ func (s *IdentityPoliciesDataSourceCrud) SetData() {
 
 		policy["time_created"] = r.TimeCreated.String()
 
+		// TODO: see comment "pending spec/sdk versionDate solution" in identity_policy_resource.go
 		if r.VersionDate != nil {
 			policy["version_date"] = *r.VersionDate
 		}

provider/identity_policy_resource.go

@@ -9,7 +9,6 @@ import (
 	"strings"
 
 	"github.com/hashicorp/terraform/helper/schema"
-	oci_common "github.com/oracle/oci-go-sdk/common"
 	oci_identity "github.com/oracle/oci-go-sdk/identity"
 
 	"github.com/oracle/terraform-provider-oci/crud"
@@ -195,9 +194,19 @@ func (s *PolicyResourceCrud) Create() error {
 	}
 
 	if versionDate, ok := s.D.GetOkExists("version_date"); ok {
-		tmp := versionDate.(oci_common.SDKTime)
+		// one off change to go sdk policy.go:57 create_policy_details.go:36 and update_policy_details.go:29 to treat this as a string
+		tmp := versionDate.(string)
 		request.VersionDate = &tmp
 	}
+	// TODO: pending spec/sdk versionDate solution to support basic `date` types, some form of this code may be required here and in `Update()` below
+	//if versionDate, ok := s.D.GetOkExists("version_date"); ok {
+	//	const scheme = `2006-01-02`
+	//	tmp, err := time.Parse(scheme, versionDate.(string))
+	//	if err != nil {
+	//		return err
+	//	}
+	//	request.VersionDate = &oci_common.SDKTime{Time: tmp}
+	//}
 
 	request.RequestMetadata.RetryPolicy = getRetryPolicy(s.DisableNotFoundRetries, "identity")
 
@@ -259,8 +268,9 @@ func (s *PolicyResourceCrud) Update() error {
 		request.Statements = tmp
 	}
 
+	// TODO: see comment "pending spec/sdk versionDate solution" above
 	if versionDate, ok := s.D.GetOkExists("version_date"); ok {
-		tmp := versionDate.(oci_common.SDKTime)
+		tmp := versionDate.(string)
 		request.VersionDate = &tmp
 	}
 

provider/identity_policy_resource_test.go

@@ -53,6 +53,7 @@ func (s *ResourceIdentityPolicyTestSuite) TestAccResourceIdentityPolicy_basic()
 					compartment_id = "${oci_identity_compartment.t.id}"
 					name = "p1-{{.token}}"
 					description = "automated test policy"
+					version_date = "2018-04-17"
 					statements = ["Allow group ${oci_identity_group.t.name} to read instances in compartment ${oci_identity_compartment.t.name}"]
 				}`, nil),
 				Check: resource.ComposeTestCheckFunc(
@@ -66,7 +67,7 @@ func (s *ResourceIdentityPolicyTestSuite) TestAccResourceIdentityPolicy_basic()
 					resource.TestCheckResourceAttr(s.ResourceName, "description", "automated test policy"),
 					resource.TestCheckResourceAttr(s.ResourceName, "statements.#", "1"),
 					resource.TestCheckResourceAttr(s.ResourceName, "state", string(identity.PolicyLifecycleStateActive)),
-					resource.TestCheckNoResourceAttr(s.ResourceName, "version_date"),
+					resource.TestCheckResourceAttr(s.ResourceName, "version_date", "2018-04-17"),
 					resource.TestCheckNoResourceAttr(s.ResourceName, "inactive_state"),
 					func(s *terraform.State) (err error) {
 						policyHash, err = fromInstanceState(s, "oci_identity_policy.p", "policyHash")
@@ -81,14 +82,16 @@ func (s *ResourceIdentityPolicyTestSuite) TestAccResourceIdentityPolicy_basic()
 					compartment_id = "${oci_identity_compartment.t.id}"
 					name = "p2-{{.token}}"
 					description = "automated test policy (updated)"
+					version_date = "2018-04-18"
 					statements = [
-						"Allow group ${oci_identity_group.t.name} to read instances in compartment ${oci_identity_compartment.t.name}",
+						"Allow group ${oci_identity_group.t.name} to inspect instances in compartment ${oci_identity_compartment.t.name}",
 						"Allow group ${oci_identity_group.t.name} to read instances in compartment ${oci_identity_compartment.t.name}"
 					]
 				}`, nil),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(s.ResourceName, "name", "p2-"+s.Token),
 					resource.TestCheckResourceAttr(s.ResourceName, "description", "automated test policy (updated)"),
+					resource.TestCheckResourceAttr(s.ResourceName, "version_date", "2018-04-18"),
 					resource.TestCheckResourceAttr(s.ResourceName, "statements.#", "2"),
 					func(s *terraform.State) (err error) {
 						newHash, err := fromInstanceState(s, "oci_identity_policy.p", "policyHash")