Merge pull request #183 from oracle/ramy-AllowDisableRetries

adding option to disable automatic retries

Author: rcohenma

docs/examples/compute/single_instance/provider.tf

@@ -3,4 +3,5 @@ provider "baremetal" {
   user_ocid = "${var.user_ocid}"
   fingerprint = "${var.fingerprint}"
   private_key_path = "${var.private_key_path}"
+  disable_auto_retries = "true"
 }

provider.go

@@ -28,6 +28,8 @@ func init() {
 			"A private_key or a private_key_path must be provided.",
 		"private_key_password": "(Optional) The password used to secure the private key.",
 		"region":               "(Optional) The region for API connections.",
+		"disable_auto_retries": "(Optional) Disable Automatic retries for retriable errors.\n" +
+			"Auto retries were introduced to solve some eventual consistency problems but it also introduced performance issues on destroy operations.",
 	}
 }
 
@@ -91,6 +93,13 @@ func schemaMap() map[string]*schema.Schema {
 			Description: descriptions["region"],
 			DefaultFunc: schema.EnvDefaultFunc("OBMCS_REGION", nil),
 		},
+		"disable_auto_retries": {
+			Type:        schema.TypeBool,
+			Optional:    true,
+			Default:     false,
+			Description: descriptions["disable_auto_retries"],
+			DefaultFunc: schema.EnvDefaultFunc("OBMCS_DISABLE_AUTO_RETRIES", nil),
+		},
 	}
 }
 
@@ -219,6 +228,7 @@ func providerConfig(d *schema.ResourceData) (client interface{}, err error) {
 	privateKeyPath, hasKeyPath := d.Get("private_key_path").(string)
 	privateKeyPassword, hasKeyPass := d.Get("private_key_password").(string)
 	region, hasRegion := d.Get("region").(string)
+	disableAutoRetries, hasDisableRetries := d.Get("disable_auto_retries").(bool)
 
 	// for internal use
 	urlTemplate := getEnvSetting("url_template", "")
@@ -258,6 +268,10 @@ func providerConfig(d *schema.ResourceData) (client interface{}, err error) {
 		clientOpts = append(clientOpts, baremetal.Region(region))
 	}
 
+	if hasDisableRetries {
+		clientOpts = append(clientOpts, baremetal.DisableAutoRetries(disableAutoRetries))
+	}
+
 	if urlTemplate != "" {
 		clientOpts = append(clientOpts, baremetal.UrlTemplate(urlTemplate))
 	}

vendor/github.com/MustWin/baremetal-sdk-go/client.go

@@ -327,10 +327,10 @@
 			"revisionTime": "2017-02-01T00:43:30Z"
 		},
 		{
-			"checksumSHA1": "R4NLurUA0rFm9zXONd9lSdFrN/w=",
+			"checksumSHA1": "kQcH7eYRiqBiQUPCNg55fwRtqgg=",
 			"path": "github.com/MustWin/baremetal-sdk-go",
-			"revision": "264b12431d5e7bb6b4c281f5a898c62200de323d",
-			"revisionTime": "2017-07-14T00:37:53Z"
+			"revision": "3875e156ba8b34e977ef1348a6838f73150dfcc8",
+			"revisionTime": "2017-07-19T23:37:31Z"
 		},
 		{
 			"checksumSHA1": "Aqy8/FoAIidY/DeQ5oTYSZ4YFVc=",